chore: upgrade ng-mocks to 14.12.1
#34
Conversation
package.json
Outdated
| @@ -21,7 +21,7 @@ | |||
| "@angular/router": "17.0.2", | |||
| "@testing-library/angular": "14.4.0", | |||
| "@testing-library/user-event": "14.5.1", | |||
| "ng-mocks": "14.11.0", | |||
| "ng-mocks": "14.12.1", | |||
There was a problem hiding this comment.
Oh this brings to my attention that we need to cleanup the dependencies 😅
@testing-library packages needs to move to devDependencies, ng-mocks isn't used and can thus be removed.
Do you want to update the PR with this?
There was a problem hiding this comment.
I can do that after work. It is 11:17 AM in my timezone so you will probably be sleeping by then. Otherwise I wouldn't mind if you want to do that now outside of the PR and close this.
There was a problem hiding this comment.
There's no rush with it.
Please take your time 🙂
There was a problem hiding this comment.
I moved two @testing-library packages to devDependencies, removed ng-mocks, and updated the package-lock.json.
|
🎉 This PR is included in version 1.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Errors occurred when trying to run ng-mocks 14.11.0. It appears that 14.12.0 was released to support Angular v17, and 14.12.1 is the latest version.
I have not done much else other than experiment with the example application. But now it seems to work.