[NFT Page] - I18N & Language Switching #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx0c
force-pushed
the
feat/i18n
branch
2 times, most recently
from
80adccb to
7df5533
Compare
tx0c
commented
Oct 22, 2021
|
|
||
| <Footer /> | ||
| </ClientContext.Provider> | ||
| <ClientContext.Provider value={client}>{children}</ClientContext.Provider> |
There was a problem hiding this comment.
it seems the plugin gatsby-theme-i18n has a bug, and here I have to move elements from layout into the page, this solution might be ok we don't have too many pages, just copy the Header and Footer to every page
Components in wrapPageElement cannot access the current locale #138
gatsbyjs/themes#138 (comment)
tx0c
added a commit
that referenced
this pull request
Oct 24, 2021
1. https://nft-develop.matters.news/ (zh-han traditional is working) 2. https://nft-develop.matters.news/en/ (english is working) 3. https://nft-develop.matters.news/zh-hans/ (not working if directly access) [NFT Page] - I18N & Language Switching #23 [NFT Page] - I18N & Language Switching 5pt feature request #9
tx0c
added a commit
that referenced
this pull request
Oct 24, 2021
1. https://nft-develop.matters.news/ (zh-han traditional is working) 2. https://nft-develop.matters.news/en/ (english is working) 3. https://nft-develop.matters.news/zh-hans/ (not working if directly access) [NFT Page] - I18N & Language Switching #23 [NFT Page] - I18N & Language Switching 5pt feature request #9
tx0c
added a commit
that referenced
this pull request
Oct 25, 2021
1. https://nft-develop.matters.news/ (zh-han traditional is working) 2. https://nft-develop.matters.news/en/ (english is working) 3. https://nft-develop.matters.news/zh-hans/ (not working if directly access) - [NFT Page] - I18N & Language Switching #23 - [NFT Page] - I18N & Language Switching 5pt feature request #9
tx0c
added a commit
that referenced
this pull request
Oct 25, 2021
1. https://nft-develop.matters.news/ (zh-han traditional is working) 2. https://nft-develop.matters.news/en/ (english is working) 3. https://nft-develop.matters.news/zh-hans/ (not working if directly access) - [NFT Page] - I18N & Language Switching #23 - [NFT Page] - I18N & Language Switching 5pt feature request #9
tx0c
added a commit
that referenced
this pull request
Oct 25, 2021
1. https://nft-develop.matters.news/ (zh-han traditional is working) 2. https://nft-develop.matters.news/en/ (english is working) 3. https://nft-develop.matters.news/zh-hans/ (not working if directly access) - [NFT Page] - I18N & Language Switching #23 - [NFT Page] - I18N & Language Switching 5pt feature request #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how about a lightweight solution like this to keep all translation messages in the source code,
when there aren't too many messages, looks more lightweight than any of
react-intl,react-i18next, orLingui.https://www.gatsbyjs.com/blog/2020-07-28-introducing-gatsby-i18n-theme/
resolves #9