fix(i18n): zh-hans not working #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx0c
force-pushed
the
fix/i18n-zh-not-working
branch
2 times, most recently
from
c5eeaa2 to
2d31f58
Compare
tx0c
force-pushed
the
fix/i18n-zh-not-working
branch
from
2d31f58 to
8806d27
Compare
1. https://nft-develop.matters.news/ (zh-han traditional is working) 2. https://nft-develop.matters.news/en/ (english is working) 3. https://nft-develop.matters.news/zh-hans/ (not working if directly access) - [NFT Page] - I18N & Language Switching #23 - [NFT Page] - I18N & Language Switching 5pt feature request #9
tx0c
force-pushed
the
fix/i18n-zh-not-working
branch
from
8806d27 to
1601608
Compare
tx0c
added a commit
that referenced
this pull request
Oct 25, 2021
should be part of #26; add ./.github/workflows/buildtest.yml to make sure `run build` should not fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems
gatsby-theme-i18nhas somewhere restriction of 2 letters only, only reproducing when deployed on S3 Cloudfront