Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept additional rules in the adjust() call #230

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Accept additional rules in the adjust() call #230

merged 3 commits into from
Jun 4, 2024

Conversation

lukaszachy
Copy link
Collaborator

@lukaszachy lukaszachy commented Apr 11, 2024

Use case: Explicit set of the rules to be applied, regardless what is in the Tree.

Could be simplified if/once #229 is merged.

fmf/base.py Outdated Show resolved Hide resolved
@lukaszachy lukaszachy changed the title Allow to provide runtime rules during adjust call Accept additional rules in the adjust call Apr 12, 2024
@lukaszachy lukaszachy requested review from happz and psss April 12, 2024 14:05
@lukaszachy lukaszachy added this to the 1.4 milestone Apr 12, 2024
@lukaszachy lukaszachy marked this pull request as ready for review April 12, 2024 14:05
fmf/base.py Outdated Show resolved Hide resolved
fmf/base.py Outdated Show resolved Hide resolved
fmf/base.py Outdated Show resolved Hide resolved
@psss
Copy link
Collaborator

psss commented Jun 4, 2024

Could be simplified if/once #229 is merged.

#229 has been merged, @lukaszachy, could you please rebase?

Use case: Explicit set of the rules to be applied, regardless what is in
the Tree.
@lukaszachy
Copy link
Collaborator Author

Rebased to the current main. As there was a conflict in fmf/base.py it was easier to squash the proposed change first.

fmf/base.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the continue statement.

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good, thanks!

@psss psss changed the title Accept additional rules in the adjust call Accept additional rules in the adjust() call Jun 4, 2024
@psss psss merged commit 673c83c into main Jun 4, 2024
10 checks passed
@psss psss deleted the adjust-add-rules branch June 4, 2024 15:10
@psss psss self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants