Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override test duration from plan #1843

Closed
pellecchialuigi opened this issue Feb 10, 2023 · 9 comments · Fixed by #2865
Closed

Override test duration from plan #1843

pellecchialuigi opened this issue Feb 10, 2023 · 9 comments · Fixed by #2865
Assignees
Labels
status | blocked The merging of PR is blocked on some other issue step | discover Stuff related to the discover step step | execute Stuff related to the execute step
Milestone

Comments

@pellecchialuigi
Copy link
Contributor

As a tester, I may need to modify some libraries that the test uses.
Those instrumentations can significantly change the test duration and I need to be able to run those tests in that scenario without requesting changes in the test fmf file.
A possible solution could be to override the duration using a mathematical operation.
example: duration: *3
example: duration: +1h

@lukaszachy lukaszachy added the status | discuss Needs more discussion before closing label Feb 15, 2023
@lukaszachy lukaszachy self-assigned this Feb 21, 2023
@lukaszachy
Copy link
Collaborator

Outcome of the discussion on the hacking session:

Create new attribute which will allow to change the duration: either to set explicit value or mathematical operation on existing value ( +1s, +1m, +1h, *1.2 )

Attribute could be used in discover phases where it will affect tests gathered in that phase as well as in execute step where it will affect all discovered tests.

@lukaszachy lukaszachy added step | execute Stuff related to the execute step step | discover Stuff related to the discover step enhancement and removed status | discuss Needs more discussion before closing labels Feb 21, 2023
@lukaszachy
Copy link
Collaborator

Use case we should cover: One arch is slower than the others so:

adjust:
 - when: arch == x86_64
   duration: '*2'

@lukaszachy lukaszachy added this to the 1.23 milestone Apr 4, 2023
@lukaszachy
Copy link
Collaborator

Lets' aim for next release.

@psss psss modified the milestones: 1.23, 1.24 Apr 25, 2023
@lukaszachy lukaszachy modified the milestones: 1.24, 1.25 Jun 1, 2023
@psss
Copy link
Collaborator

psss commented Jun 27, 2023

Has the essential part of the use case been covered by #1972? Currently duration allows to provide multiple values:

# Combination & repetition of time suffixes (total 4h 2m 3s)
duration: 1h 3h 2m 3

So it's possible to use context adjust to extend it with a custom value. Is the multiplication support important enough to dive into this now?

@lukaszachy
Copy link
Collaborator

Unfortunatelly we are still missing way how to modify duration from the PLAN, which is necessary when

  • one cannot modify test repo
  • plan changes duration significantly (e.g. experiment on very slow machine, or running with profiling, custom LD_PRELOAD....)

@psss
Copy link
Collaborator

psss commented Jun 27, 2023

Ah, I see, the plan part is here essential.

@lukaszachy lukaszachy modified the milestones: 1.25, 1.26 Jun 27, 2023
@psss psss modified the milestones: 1.26, 1.27 Jul 25, 2023
@thrix thrix modified the milestones: 1.27, 1.28 Aug 22, 2023
@psss psss modified the milestones: 1.28, 1.29 Sep 26, 2023
@happz
Copy link
Collaborator

happz commented Oct 24, 2023

@lukaszachy is this issue going to land in 1.29? I'd propose postponing once more to 1.30.

@lukaszachy lukaszachy modified the milestones: 1.29, 1.30 Oct 25, 2023
@lukaszachy
Copy link
Collaborator

Started #2430

@happz happz removed this from the 1.30 milestone Nov 21, 2023
@happz happz added this to the 1.31 milestone Nov 21, 2023
@lukaszachy lukaszachy modified the milestones: 1.31, 1.32 Jan 17, 2024
@thrix thrix modified the milestones: 1.32, 1.33 Feb 20, 2024
@lukaszachy
Copy link
Collaborator

lukaszachy commented Apr 11, 2024

Status comment:

Not sure if 1.33 is feasible as the third point will require fmf release to happen first.

@lukaszachy lukaszachy added the status | blocked The merging of PR is blocked on some other issue label Apr 11, 2024
@lukaszachy lukaszachy linked a pull request Apr 16, 2024 that will close this issue
7 tasks
@lukaszachy lukaszachy modified the milestones: 1.33, 1.34 Apr 30, 2024
@lukaszachy lukaszachy modified the milestones: 1.34, 1.35 Jun 6, 2024
@martinhoyer martinhoyer modified the milestones: 1.35, 1.36 Jul 30, 2024
@lukaszachy lukaszachy modified the milestones: 1.36, 1.37 Aug 27, 2024
@psss psss removed the enhancement label Sep 17, 2024
@thrix thrix modified the milestones: 1.37, 1.38 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status | blocked The merging of PR is blocked on some other issue step | discover Stuff related to the discover step step | execute Stuff related to the execute step
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants