Skip to content

Refactor dayPeriod formatting tests to be robust to CLDR changes #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptomato merged 1 commit into from
Apr 11, 2025
Merged

Refactor dayPeriod formatting tests to be robust to CLDR changes #4447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 63 additions & 75 deletions test/intl402/DateTimeFormat/prototype/format/dayPeriod-long-en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,88 +6,76 @@ esid: sec-createdatetimeformat
description: Checks basic handling of dayPeriod, long format.
features: [Intl.DateTimeFormat-dayPeriod]
locale: [en]
includes: [compareArray.js]
---*/

const d0000 = new Date(2017, 11, 12, 0, 0, 0, 0);
const d0100 = new Date(2017, 11, 12, 1, 0, 0, 0);
const d0200 = new Date(2017, 11, 12, 2, 0, 0, 0);
const d0300 = new Date(2017, 11, 12, 3, 0, 0, 0);
const d0400 = new Date(2017, 11, 12, 4, 0, 0, 0);
const d0500 = new Date(2017, 11, 12, 5, 0, 0, 0);
const d0600 = new Date(2017, 11, 12, 6, 0, 0, 0);
const d0700 = new Date(2017, 11, 12, 7, 0, 0, 0);
const d0800 = new Date(2017, 11, 12, 8, 0, 0, 0);
const d0900 = new Date(2017, 11, 12, 9, 0, 0, 0);
const d1000 = new Date(2017, 11, 12, 10, 0, 0, 0);
const d1100 = new Date(2017, 11, 12, 11, 0, 0, 0);
const d1200 = new Date(2017, 11, 12, 12, 0, 0, 0);
const d1300 = new Date(2017, 11, 12, 13, 0, 0, 0);
const d1400 = new Date(2017, 11, 12, 14, 0, 0, 0);
const d1500 = new Date(2017, 11, 12, 15, 0, 0, 0);
const d1600 = new Date(2017, 11, 12, 16, 0, 0, 0);
const d1700 = new Date(2017, 11, 12, 17, 0, 0, 0);
const d1800 = new Date(2017, 11, 12, 18, 0, 0, 0);
const d1900 = new Date(2017, 11, 12, 19, 0, 0, 0);
const d2000 = new Date(2017, 11, 12, 20, 0, 0, 0);
const d2100 = new Date(2017, 11, 12, 21, 0, 0, 0);
const d2200 = new Date(2017, 11, 12, 22, 0, 0, 0);
const d2300 = new Date(2017, 11, 12, 23, 0, 0, 0);
// Each expected dayPeriod value must be a) contiguous, and
// b) represented in sequence.
var expectedDayPeriods = [
'in the morning',
'noon',
'in the afternoon',
'in the evening',
'at night'
];

const long = new Intl.DateTimeFormat('en', {
// Cover all 24 hours of a single day.
var inputs = [];
for (var h = 0; h < 24; h++) {
inputs.push(new Date(2017, 11, 12, h, 0, 0, 0));
}

// Verify complete and exclusive representation.
var formatter = new Intl.DateTimeFormat('en', {
dayPeriod: 'long'
});
var observedDayPeriods = [];
var unexpectedDayPeriods = [];
for (var h = 0; h < 24; h++) {
var dayPeriod = formatter.format(inputs[h]);
observedDayPeriods.push(dayPeriod);
if (expectedDayPeriods.indexOf(dayPeriod) === -1) {
unexpectedDayPeriods.push(dayPeriod);
}
}
var unusedDayPeriods = expectedDayPeriods.filter(function (dayPeriod) {
return observedDayPeriods.indexOf(dayPeriod) === -1;
});
assert.compareArray(unexpectedDayPeriods, [],
'unexpected dayPeriods: ' + unexpectedDayPeriods.join());
assert.compareArray(unusedDayPeriods, [],
'unused dayPeriods: ' + unusedDayPeriods.join());

assert.sameValue(long.format(d0000), 'at night', '00:00, long format');
assert.sameValue(long.format(d0100), 'at night', '01:00, long format');
assert.sameValue(long.format(d0200), 'at night', '02:00, long format');
assert.sameValue(long.format(d0300), 'at night', '03:00, long format');
assert.sameValue(long.format(d0400), 'at night', '04:00, long format');
assert.sameValue(long.format(d0500), 'at night', '05:00, long format');
assert.sameValue(long.format(d0600), 'in the morning', '06:00, long format');
assert.sameValue(long.format(d0700), 'in the morning', '07:00, long format');
assert.sameValue(long.format(d0800), 'in the morning', '08:00, long format');
assert.sameValue(long.format(d0900), 'in the morning', '09:00, long format');
assert.sameValue(long.format(d1000), 'in the morning', '10:00, long format');
assert.sameValue(long.format(d1100), 'in the morning', '11:00, long format');
assert.sameValue(long.format(d1200), 'noon', '12:00, long format');
assert.sameValue(long.format(d1300), 'in the afternoon', '13:00, long format');
assert.sameValue(long.format(d1400), 'in the afternoon', '14:00, long format');
assert.sameValue(long.format(d1500), 'in the afternoon', '15:00, long format');
assert.sameValue(long.format(d1600), 'in the afternoon', '16:00, long format');
assert.sameValue(long.format(d1700), 'in the afternoon', '17:00, long format');
assert.sameValue(long.format(d1800), 'in the evening', '18:00, long format');
assert.sameValue(long.format(d1900), 'in the evening', '19:00, long format');
assert.sameValue(long.format(d2000), 'in the evening', '20:00, long format');
assert.sameValue(long.format(d2100), 'at night', '21:00, long format');
assert.sameValue(long.format(d2200), 'at night', '22:00, long format');
assert.sameValue(long.format(d2300), 'at night', '23:00, long format');
function arrayAt(arr, relIndex) {
var realIndex = relIndex < 0 ? arr.length + relIndex : relIndex;
if (realIndex < 0 || realIndex >= arr.length) return undefined;
return arr[realIndex];
}

const longNumeric = new Intl.DateTimeFormat('en', {
// Verify ordering, accounting for the possibility of one value spanning day
// transitions.
var transitionCount = 0;
for (var h = 0; h < 24; h++) {
var dayPeriod = observedDayPeriods[h];
var prevDayPeriod = arrayAt(observedDayPeriods, h - 1);
if (dayPeriod === prevDayPeriod) continue;
transitionCount++;
var i = expectedDayPeriods.indexOf(dayPeriod);
assert.sameValue(prevDayPeriod, arrayAt(expectedDayPeriods, i - 1),
dayPeriod + ' must be preceded by ' + prevDayPeriod);
}
assert.sameValue(transitionCount, expectedDayPeriods.length,
'dayPeriods must be contiguous');

var numericFormatter = new Intl.DateTimeFormat('en', {
dayPeriod: 'long',
hour: 'numeric'
});

assert.sameValue(longNumeric.format(d0000), '12 at night', '00:00, long-numeric');
assert.sameValue(longNumeric.format(d0100), '1 at night', '01:00, long-numeric');
assert.sameValue(longNumeric.format(d0200), '2 at night', '02:00, long-numeric');
assert.sameValue(longNumeric.format(d0300), '3 at night', '03:00, long-numeric');
assert.sameValue(longNumeric.format(d0400), '4 at night', '04:00, long-numeric');
assert.sameValue(longNumeric.format(d0500), '5 at night', '05:00, long-numeric');
assert.sameValue(longNumeric.format(d0600), '6 in the morning', '06:00, long-numeric');
assert.sameValue(longNumeric.format(d0700), '7 in the morning', '07:00, long-numeric');
assert.sameValue(longNumeric.format(d0800), '8 in the morning', '08:00, long-numeric');
assert.sameValue(longNumeric.format(d0900), '9 in the morning', '09:00, long-numeric');
assert.sameValue(longNumeric.format(d1000), '10 in the morning', '10:00, long-numeric');
assert.sameValue(longNumeric.format(d1100), '11 in the morning', '11:00, long-numeric');
assert.sameValue(longNumeric.format(d1200), '12 noon', '12:00, long-numeric');
assert.sameValue(longNumeric.format(d1300), '1 in the afternoon', '13:00, long-numeric');
assert.sameValue(longNumeric.format(d1400), '2 in the afternoon', '14:00, long-numeric');
assert.sameValue(longNumeric.format(d1500), '3 in the afternoon', '15:00, long-numeric');
assert.sameValue(longNumeric.format(d1600), '4 in the afternoon', '16:00, long-numeric');
assert.sameValue(longNumeric.format(d1700), '5 in the afternoon', '17:00, long-numeric');
assert.sameValue(longNumeric.format(d1800), '6 in the evening', '18:00, long-numeric');
assert.sameValue(longNumeric.format(d1900), '7 in the evening', '19:00, long-numeric');
assert.sameValue(longNumeric.format(d2000), '8 in the evening', '20:00, long-numeric');
assert.sameValue(longNumeric.format(d2100), '9 at night', '21:00, long-numeric');
assert.sameValue(longNumeric.format(d2200), '10 at night', '22:00, long-numeric');
assert.sameValue(longNumeric.format(d2300), '11 at night', '23:00, long-numeric');
for (var h = 0; h < 24; h++) {
assert.sameValue(
numericFormatter.format(inputs[h]),
// Hour "00" is represented as "12".
((h % 12) || 12) + ' ' + observedDayPeriods[h],
'numeric hour must precede dayPeriod'
);
}
138 changes: 63 additions & 75 deletions test/intl402/DateTimeFormat/prototype/format/dayPeriod-narrow-en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,88 +6,76 @@ esid: sec-createdatetimeformat
description: Checks basic handling of dayPeriod, narrow format.
features: [Intl.DateTimeFormat-dayPeriod]
locale: [en]
includes: [compareArray.js]
---*/

const d0000 = new Date(2017, 11, 12, 0, 0, 0, 0);
const d0100 = new Date(2017, 11, 12, 1, 0, 0, 0);
const d0200 = new Date(2017, 11, 12, 2, 0, 0, 0);
const d0300 = new Date(2017, 11, 12, 3, 0, 0, 0);
const d0400 = new Date(2017, 11, 12, 4, 0, 0, 0);
const d0500 = new Date(2017, 11, 12, 5, 0, 0, 0);
const d0600 = new Date(2017, 11, 12, 6, 0, 0, 0);
const d0700 = new Date(2017, 11, 12, 7, 0, 0, 0);
const d0800 = new Date(2017, 11, 12, 8, 0, 0, 0);
const d0900 = new Date(2017, 11, 12, 9, 0, 0, 0);
const d1000 = new Date(2017, 11, 12, 10, 0, 0, 0);
const d1100 = new Date(2017, 11, 12, 11, 0, 0, 0);
const d1200 = new Date(2017, 11, 12, 12, 0, 0, 0);
const d1300 = new Date(2017, 11, 12, 13, 0, 0, 0);
const d1400 = new Date(2017, 11, 12, 14, 0, 0, 0);
const d1500 = new Date(2017, 11, 12, 15, 0, 0, 0);
const d1600 = new Date(2017, 11, 12, 16, 0, 0, 0);
const d1700 = new Date(2017, 11, 12, 17, 0, 0, 0);
const d1800 = new Date(2017, 11, 12, 18, 0, 0, 0);
const d1900 = new Date(2017, 11, 12, 19, 0, 0, 0);
const d2000 = new Date(2017, 11, 12, 20, 0, 0, 0);
const d2100 = new Date(2017, 11, 12, 21, 0, 0, 0);
const d2200 = new Date(2017, 11, 12, 22, 0, 0, 0);
const d2300 = new Date(2017, 11, 12, 23, 0, 0, 0);
// Each expected dayPeriod value must be a) contiguous, and
// b) represented in sequence.
var expectedDayPeriods = [
'in the morning',
'n',
'in the afternoon',
'in the evening',
'at night'
];

const narrow = new Intl.DateTimeFormat('en', {
// Cover all 24 hours of a single day.
var inputs = [];
for (var h = 0; h < 24; h++) {
inputs.push(new Date(2017, 11, 12, h, 0, 0, 0));
}

// Verify complete and exclusive representation.
var formatter = new Intl.DateTimeFormat('en', {
dayPeriod: 'narrow'
});
var observedDayPeriods = [];
var unexpectedDayPeriods = [];
for (var h = 0; h < 24; h++) {
var dayPeriod = formatter.format(inputs[h]);
observedDayPeriods.push(dayPeriod);
if (expectedDayPeriods.indexOf(dayPeriod) === -1) {
unexpectedDayPeriods.push(dayPeriod);
}
}
var unusedDayPeriods = expectedDayPeriods.filter(function (dayPeriod) {
return observedDayPeriods.indexOf(dayPeriod) === -1;
});
assert.compareArray(unexpectedDayPeriods, [],
'unexpected dayPeriods: ' + unexpectedDayPeriods.join());
assert.compareArray(unusedDayPeriods, [],
'unused dayPeriods: ' + unusedDayPeriods.join());

assert.sameValue(narrow.format(d0000), 'at night', '00:00, narrow format');
assert.sameValue(narrow.format(d0100), 'at night', '01:00, narrow format');
assert.sameValue(narrow.format(d0200), 'at night', '02:00, narrow format');
assert.sameValue(narrow.format(d0300), 'at night', '03:00, narrow format');
assert.sameValue(narrow.format(d0400), 'at night', '04:00, narrow format');
assert.sameValue(narrow.format(d0500), 'at night', '05:00, narrow format');
assert.sameValue(narrow.format(d0600), 'in the morning', '06:00, narrow format');
assert.sameValue(narrow.format(d0700), 'in the morning', '07:00, narrow format');
assert.sameValue(narrow.format(d0800), 'in the morning', '08:00, narrow format');
assert.sameValue(narrow.format(d0900), 'in the morning', '09:00, narrow format');
assert.sameValue(narrow.format(d1000), 'in the morning', '10:00, narrow format');
assert.sameValue(narrow.format(d1100), 'in the morning', '11:00, narrow format');
assert.sameValue(narrow.format(d1200), 'n', '12:00, narrow format');
assert.sameValue(narrow.format(d1300), 'in the afternoon', '13:00, narrow format');
assert.sameValue(narrow.format(d1400), 'in the afternoon', '14:00, narrow format');
assert.sameValue(narrow.format(d1500), 'in the afternoon', '15:00, narrow format');
assert.sameValue(narrow.format(d1600), 'in the afternoon', '16:00, narrow format');
assert.sameValue(narrow.format(d1700), 'in the afternoon', '17:00, narrow format');
assert.sameValue(narrow.format(d1800), 'in the evening', '18:00, narrow format');
assert.sameValue(narrow.format(d1900), 'in the evening', '19:00, narrow format');
assert.sameValue(narrow.format(d2000), 'in the evening', '20:00, narrow format');
assert.sameValue(narrow.format(d2100), 'at night', '21:00, narrow format');
assert.sameValue(narrow.format(d2200), 'at night', '22:00, narrow format');
assert.sameValue(narrow.format(d2300), 'at night', '23:00, narrow format');
function arrayAt(arr, relIndex) {
var realIndex = relIndex < 0 ? arr.length + relIndex : relIndex;
if (realIndex < 0 || realIndex >= arr.length) return undefined;
return arr[realIndex];
}

const narrowNumeric = new Intl.DateTimeFormat('en', {
// Verify ordering, accounting for the possibility of one value spanning day
// transitions.
var transitionCount = 0;
for (var h = 0; h < 24; h++) {
var dayPeriod = observedDayPeriods[h];
var prevDayPeriod = arrayAt(observedDayPeriods, h - 1);
if (dayPeriod === prevDayPeriod) continue;
transitionCount++;
var i = expectedDayPeriods.indexOf(dayPeriod);
assert.sameValue(prevDayPeriod, arrayAt(expectedDayPeriods, i - 1),
dayPeriod + ' must be preceded by ' + prevDayPeriod);
}
assert.sameValue(transitionCount, expectedDayPeriods.length,
'dayPeriods must be contiguous');

var numericFormatter = new Intl.DateTimeFormat('en', {
dayPeriod: 'narrow',
hour: 'numeric'
});

assert.sameValue(narrowNumeric.format(d0000), '12 at night', '00:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0100), '1 at night', '01:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0200), '2 at night', '02:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0300), '3 at night', '03:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0400), '4 at night', '04:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0500), '5 at night', '05:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0600), '6 in the morning', '06:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0700), '7 in the morning', '07:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0800), '8 in the morning', '08:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d0900), '9 in the morning', '09:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1000), '10 in the morning', '10:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1100), '11 in the morning', '11:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1200), '12 n', '12:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1300), '1 in the afternoon', '13:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1400), '2 in the afternoon', '14:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1500), '3 in the afternoon', '15:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1600), '4 in the afternoon', '16:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1700), '5 in the afternoon', '17:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1800), '6 in the evening', '18:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d1900), '7 in the evening', '19:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d2000), '8 in the evening', '20:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d2100), '9 at night', '21:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d2200), '10 at night', '22:00, narrow-numeric');
assert.sameValue(narrowNumeric.format(d2300), '11 at night', '23:00, narrow-numeric');
for (var h = 0; h < 24; h++) {
assert.sameValue(
numericFormatter.format(inputs[h]),
// Hour "00" is represented as "12".
((h % 12) || 12) + ' ' + observedDayPeriods[h],
'numeric hour must precede dayPeriod'
);
}
Loading