-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
play: support tls options #1078
Merged
oleg-jukovec
merged 1 commit into
master
from
patapenka-alexey/gh-1067-play-support-tls-options
Jan 10, 2025
Merged
play: support tls options #1078
oleg-jukovec
merged 1 commit into
master
from
patapenka-alexey/gh-1067-play-support-tls-options
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8643840
to
1a79b61
Compare
oleg-jukovec
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add a list of new flags to the TarantoolBot comment.
278454a
to
bf6bb5f
Compare
oleg-jukovec
reviewed
Jan 3, 2025
oleg-jukovec
reviewed
Jan 3, 2025
bf6bb5f
to
80530d4
Compare
oleg-jukovec
reviewed
Jan 8, 2025
oleg-jukovec
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but don't forget to fix the comment.
@TarantoolBot document Title: play: add TLS options This patch adds support of the ssl parameters to the `tt play` command by using flags: `sslkeyfile` - path to a private SSL key file, `sslcertfile` - path to an SSL certificate file, `sslcafile` - path to a trusted certificate authorities (CA) file, `sslciphers` - colon-separated (:) list of SSL cipher suites the connection. Closes #1067
80530d4
to
1d3e270
Compare
dmyger
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
play: add TLS options
@TarantoolBot document
Title: play: add TLS options
This patch adds support of the ssl parameters to the
tt play
commandby using flags:
sslkeyfile
- path to a private SSL key file,sslcertfile
- path to an SSL certificate file,sslcafile
- path to a trusted certificate authorities (CA) file,sslciphers
- colon-separated (:) list of SSL cipher suites the connection.Closes #1067