aeon: added the ability to connect from the config #1094
+49
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrLitkevich
force-pushed
the
TNTP-1073
branch
from
26df615 to
5a3a88e
Compare
AlexandrLitkevich
changed the title
AlexandrLitkevich
changed the title
AlexandrLitkevich
force-pushed
the
TNTP-1073
branch
2 times, most recently
from
47a20b7 to
ec98a99
Compare
Closes #TNTP-1073
AlexandrLitkevich
force-pushed
the
TNTP-1073
branch
from
661d0a3 to
b16f839
Compare
AlexandrLitkevich
requested review from
dmyger,
patapenka-alexey and
oleg-jukovec
| func newAeonConnectCmd() *cobra.Command { | ||
| var aeonCmd = &cobra.Command{ | ||
| Use: "connect URI", | ||
| Short: "Connect to the aeon instance", | ||
| Long: `Connect to the aeon instance. | ||
| tt aeon connect localhost:50051 | ||
| tt aeon connect unix://<socket-path>`, | ||
| tt aeon connect unix://<socket-path> | ||
| tt aeon connect -c path instanceName>`, |
There was a problem hiding this comment.
Suggested change
| tt aeon connect -c path instanceName>`, | |
| tt aeon connect -c /path/to/config -i INSTANCE_NAME`, |
To correlate with tt connect/play help style.
|
|
||
| us, ok := uri.(string) | ||
| if !ok { | ||
| return fmt.Errorf("it is impossible to result in a string") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("it is impossible to result in a string") | |
| return errors.New("it is impossible to cast result in a string") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aeon: added the ability to connect from the config
Closes #TNTP-1073