Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage tooling, update test tooling and improve coverage #18

Closed
wants to merge 1 commit into from
Closed

Add coverage tooling, update test tooling and improve coverage #18

wants to merge 1 commit into from

Conversation

no1seman
Copy link

@no1seman no1seman commented Oct 2, 2021

  1. Update luatest, luacheck module versions
  2. Add coverage tooling
  3. Add Makefile
  4. Minor coverage Improvements

@no1seman no1seman requested review from Totktonada and olegrok October 2, 2021 11:51
@no1seman no1seman changed the title Add coverage tooloing, update test tooling and improve coverage Add coverage tooling, update test tooling and improve coverage Oct 2, 2021
olegrok
olegrok reviewed Oct 3, 2021
View reviewed changes
Copy link
Collaborator

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch. See my comments below.

Also commit message is empty. Please add info about your changes.

.luacov Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
graphql/execute.lua Outdated Show resolved Hide resolved
@no1seman no1seman requested a review from olegrok October 3, 2021 10:19
@Totktonada
Copy link
Member

It looks relevant to lunarmodules/luacov#52, but this problem is not mentioned anywhere.

@olegrok
Copy link
Collaborator

olegrok commented Oct 11, 2021

It looks relevant to keplerproject/luacov#52, but this problem is not mentioned anywhere.

Personally, I'm not sure that it's significant reason for making code uglier.

DifferentialOrange pushed a commit that referenced this pull request Nov 15, 2021
@no1seman @DifferentialOrange
Bump Tarantool and tools versions in tests
3bd94b4 
Based on PR #18 by @no1seman
DifferentialOrange added a commit that referenced this pull request Nov 15, 2021
@DifferentialOrange
Measure test coverage
b68ef16 
Add Makefile for convenient local run. Use Makefile in test CI.
Add luacov dependency and run luatest with coverage.
Keep /tmp for luacov reports.

Based on PR #18 by @no1seman
DifferentialOrange added a commit that referenced this pull request Nov 15, 2021
@DifferentialOrange
Improve test coverage
fedcbf7 
Last line in multiline table considered as non-covered by luacov
if it has no trailing comma. See more about the issue in luacov repo:
lunarmodules/luacov#52

Based on PR #18 by @no1seman
DifferentialOrange added a commit that referenced this pull request Nov 15, 2021
@DifferentialOrange
Improve test coverage
7a74b4c 
Last line in multiline table considered as non-covered by luacov
if it has no trailing comma. See more about the issue in luacov repo:
lunarmodules/luacov#52

Based on PR #18 by @no1seman
@DifferentialOrange DifferentialOrange mentioned this pull request Nov 15, 2021
Merged
@DifferentialOrange
Copy link
Member

DifferentialOrange commented Nov 15, 2021 •
edited
Loading

I was finishing this PR as a part of this sprint tasks. You can see reworked version in #24 . Since this PR is based on branch of no1seman/graphql which I have no access to, I have opened a new PR.

DifferentialOrange added a commit that referenced this pull request Nov 15, 2021
@DifferentialOrange
Improve test coverage
5fd4155 
Last entries line in multiline table considered as non-covered by luacov
if it has no trailing comma. See more about the issue in luacov repo:
lunarmodules/luacov#52

Based on PR #18 by @no1seman
This was referenced Nov 15, 2021
Merged
Merged
DifferentialOrange added a commit that referenced this pull request Nov 18, 2021
@DifferentialOrange
Measure test coverage
4c5b458 
Add Makefile for convenient local run. Use Makefile in test CI.
Add luacov dependency and run luatest with coverage.
Keep /tmp for luacov reports.

Based on PR #18 by @no1seman
DifferentialOrange added a commit that referenced this pull request Nov 18, 2021
@DifferentialOrange
Improve test coverage
ba8857c 
Last entries line in multiline table considered as non-covered by luacov
if it has no trailing comma. See more about the issue in luacov repo:
lunarmodules/luacov#52

Based on PR #18 by @no1seman
Totktonada pushed a commit that referenced this pull request Nov 18, 2021
@no1seman @Totktonada
Bump Tarantool and tools versions in tests
965bb6c 
Based on PR #18 by @no1seman
Totktonada pushed a commit that referenced this pull request Nov 18, 2021
@DifferentialOrange @Totktonada
Measure test coverage
cd375d0 
Add Makefile for convenient local run. Use Makefile in test CI.
Add luacov dependency and run luatest with coverage.
Keep /tmp for luacov reports.

Based on PR #18 by @no1seman
Totktonada pushed a commit that referenced this pull request Nov 18, 2021
@DifferentialOrange @Totktonada
Improve test coverage
b7eaca4 
Last entries line in multiline table considered as non-covered by luacov
if it has no trailing comma. See more about the issue in luacov repo:
lunarmodules/luacov#52

Based on PR #18 by @no1seman
@DifferentialOrange
Copy link
Member

Closed by #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Awaiting requested review from Totktonada

@olegrok olegrok Awaiting requested review from olegrok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@no1seman @Totktonada @olegrok @DifferentialOrange