Support custom directives #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DifferentialOrange
force-pushed
the
DifferentialOrange/no1seman-custom_directives
branch
from
2c6add9 to
c01d3ff
Compare
olegrok
reviewed
Nov 17, 2021
olegrok
reviewed
Nov 17, 2021
olegrok
reviewed
Nov 17, 2021
olegrok
reviewed
Nov 17, 2021
DifferentialOrange
force-pushed
the
DifferentialOrange/no1seman-custom_directives
branch
6 times, most recently
from
b7a78c5 to
a524ba7
Compare
olegrok
reviewed
Nov 23, 2021
olegrok
reviewed
Nov 23, 2021
DifferentialOrange
force-pushed
the
DifferentialOrange/no1seman-custom_directives
branch
from
a524ba7 to
a53f72a
Compare
olegrok
approved these changes
Nov 23, 2021
| function g.test_util_map_name() | ||
| local res = util.map_name(nil, nil) | ||
| t.assert_equals(res, {}) | ||
| res = util.map_name({ { name = 'a' }, { name = 'b' }, }, function(v) return v end) |
There was a problem hiding this comment.
I think we can test tables that contains not only numeric keys since we use "pairs" inside this function.
There was a problem hiding this comment.
Added new test case
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
force-pushed
the
DifferentialOrange/no1seman-custom_directives
branch
from
a53f72a to
cb448ae
Compare
Totktonada
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL custom directives was introduced in spec #3.13 in October 2021 release. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives.
This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2.
Based on PR #20 by @no1seman . No major changes was introduced: minor syntax and test cases fixes, add commit message description, removed #18 and #19 commits.