Moved LinkLogin and futures to login_oauth.
#303
Conversation
tidalapi/session.py
Outdated
| @@ -644,7 +646,7 @@ def load_session_from_file(self, session_file: Path): | |||
|
|
|||
| return self.load_oauth_session(**args) | |||
|
|
|||
| def _login_with_link(self) -> Tuple[LinkLogin, concurrent.futures.Future[Any]]: | |||
| def _login_with_link(self) -> JsonObj: | |||
There was a problem hiding this comment.
This method should not be a private method if 3rd party libs plan to access it directly. I also suggest adding doxygen for the same reason as above.
It should also be renamed, since its purpose will have changed significantly. Perhaps something like oauth_request_device_auth()
There was a problem hiding this comment.
You are totally right. Excuse me this sloppy PR. I will do a proper refactoring and re-submit this PR.
There was a problem hiding this comment.
No problem at all :)
… considered private. `LinkLogin` is used instead of `JsonObj`. Docstrings are added.
|
I got a proper update. Would be very happy about your opinion. You can see here, how I would use it: https://github.com/exislow/tidal-dl-ng/blob/f2b3cc2505f4c64f09efacd775de3390ae204be0/tidal_dl_ng/gui.py#L134-L155 |
Thanks for the refactor, this is a neat way to perform the login. I was never happy with the hacks needed in mopidy-tidal so this is a good example of how it can be done in a different way. Works as expected, thanks for the added docstring btw.. Merging... 👍 |
|
I am glad you liked it! Really like how I easily we can work together on this project. Thank you. |
No description provided.