Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong determination of file extensions. Fixes tamland/python-ti… #305

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

exislow
Copy link
Contributor

@exislow exislow commented Nov 14, 2024

…dal#304

@tehkillerbee
Copy link
Collaborator

This looks like a better solution. I struggled with the same issue and ended up with the current (wrong) implementation when deciding which file extension to use.

This might break some of the unit tests though. Have you checked if they still pass? (make test)

@exislow
Copy link
Contributor Author

exislow commented Nov 14, 2024

Glad, I could help here. I have fixed the relevant test.

@exislow
Copy link
Contributor Author

exislow commented Nov 20, 2024

I was wondering, if it is possible to get this PR as a hotfix release anytime soon? Maybe also together with my other PR #303

Thanks!

@exislow
Copy link
Contributor Author

exislow commented Nov 27, 2024

@tamland: Anything else I can help with?

@tehkillerbee
Copy link
Collaborator

@exislow Sorry, I have not had time to look at this PRs yet. I will take a look ASAP and merge them in.

Let me know if you are planning more PRs, otherwise I will update the latest release with your changes.

@exislow
Copy link
Contributor Author

exislow commented Nov 27, 2024

I can totally understand this -- no worries. No other PRs planned so far.

@tehkillerbee
Copy link
Collaborator

Thanks, LGTM! Merged. 👍

@tehkillerbee tehkillerbee merged commit 6e3a4e6 into tamland:master Nov 27, 2024
5 checks passed
@exislow exislow deleted the 304-file-extension branch December 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants