-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out IO management into standalone app. #34
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| // Copyright (c) 2020, Sylabs, Inc. All rights reserved. | ||
|
|
||
| package iomanager | ||
|
|
||
| import ( | ||
| "strings" | ||
|
|
||
| "github.com/nats-io/nats.go" | ||
| "github.com/sirupsen/logrus" | ||
| "github.com/sylabs/compute-service/internal/pkg/rediskv" | ||
| ) | ||
|
|
||
| // Config describes the IO manager configuration. | ||
| type Config struct { | ||
| Version string | ||
| NATSConn *nats.Conn | ||
| RedisConn *rediskv.Connection | ||
| } | ||
|
|
||
| // IOManager contains the state of the IO Manager. | ||
| type IOManager struct { | ||
| nc *nats.Conn | ||
| rc *rediskv.Connection | ||
| subs []*nats.Subscription | ||
| } | ||
|
|
||
| // New returns a new IO Manager. | ||
| func New(c Config) (m IOManager, err error) { | ||
| return IOManager{ | ||
| c.NATSConn, | ||
| c.RedisConn, | ||
| nil, | ||
| }, nil | ||
| } | ||
|
|
||
| // Start starts the IO Manager by initializing handlers for | ||
| // NATS subscriptions. | ||
| func (m IOManager) Start() { | ||
| // Subscribe to relevant topics. | ||
| if err := m.subscribe(); err != nil { | ||
| logrus.WithError(err).Warn("failed to subscribe") | ||
| return | ||
| } | ||
| } | ||
|
|
||
| // Stop stops the IO Manager by putting NATS subscriptions | ||
| // in a draining state. | ||
| func (m IOManager) Stop() error { | ||
| return m.unsubscribe() | ||
| } | ||
|
|
||
| // subscribe expresses interest in subjects that are relevant to the IO Manager. | ||
| func (m IOManager) subscribe() error { | ||
| subs := []struct { | ||
| subject string | ||
| handler nats.MsgHandler | ||
| }{ | ||
| {"job.*.output", m.jobOutputHandler}, | ||
| } | ||
| for _, s := range subs { | ||
| sub, err := m.nc.Subscribe(s.subject, s.handler) | ||
| if err != nil { | ||
| logrus.WithField("subject", s.subject).WithError(err).Warn("failed to subscribe") | ||
| return err | ||
| } | ||
| logrus.WithField("subject", s.subject).Info("subscribed") | ||
|
|
||
| m.subs = append(m.subs, sub) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // subscribe removes interest in subjects that are relevant to the IO Manager. | ||
| // NOTE: NATS will continue to handle callbacks until queue is empty. | ||
| func (m IOManager) unsubscribe() error { | ||
| for _, s := range m.subs { | ||
| err := s.Drain() | ||
| if err != nil { | ||
| logrus.WithField("subject", s.Subject).WithError(err).Warn("failed to unsubscribe") | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // NOTE: If multiple jobOutputHandlers are spun off, output for a job could be placed | ||
| // out of order in Redis. | ||
| func (m IOManager) jobOutputHandler(msg *nats.Msg) { | ||
| // Parse subject for job ID | ||
| s := strings.Split(msg.Subject, ".") | ||
| if len(s) != 3 { | ||
| logrus.Errorf("malformed job output subject: %s, skipping", msg.Subject) | ||
| } | ||
|
|
||
| id := s[1] | ||
| if err := m.rc.Append(id, string(msg.Data)); err != nil { | ||
| logrus.Errorf("failed to append job %s output: %v", id, err) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this we might need to solve at some point, as we'll hit it during rolling upgrades. Maybe we should open an issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see this being an issue when scaling horizontally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Captured in #35