Split out IO management into standalone app. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tri-adam
requested changes
Feb 20, 2020
| } | ||
|
|
||
| // NOTE: If multiple jobOutputHandlers are spun off, output for a job couple be placed | ||
| // out of order in Redis. |
There was a problem hiding this comment.
Yeah, this we might need to solve at some point, as we'll hit it during rolling upgrades. Maybe we should open an issue for that?
There was a problem hiding this comment.
I also see this being an issue when scaling horizontally.
ikaneshiro
force-pushed
the
job-io-improve
branch
2 times, most recently
from
7c7e45d to
89ba514
Compare
Signed-off-by: Ian Kaneshiro <[email protected]>
ikaneshiro
force-pushed
the
job-io-improve
branch
from
89ba514 to
fe89383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Kaneshiro [email protected]