Skip to content

Commit

Permalink
Merge pull request #89 from superstreamlabs/staging
Browse files Browse the repository at this point in the history
0.1.21
  • Loading branch information
valeraBr authored Nov 14, 2024
2 parents dd9dffc + 63300b6 commit e49dfed
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 22 deletions.
11 changes: 7 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Please describe the tests you ran to verify your changes and note any relevant details for your test configuration.
- [ ] Test A
- [ ] Test B

Expand All @@ -12,12 +12,15 @@ Please describe the tests that you ran to verify your changes. Please also note
- [ ] I have verified that the specification is met and all functionalities are working as expected

## Reviewer Score - 0-100%

- [ ] **Meeting Task Specifications (40%)**
- [ ] **Tests have been done and meaningfully described - (25%)**
- Ensure all necessary tests are conducted, covering the critical paths and edge cases.
- Descriptions should be clear, documenting the test intent, steps, and outcomes for reproducibility and transparency.

- [ ] **Meeting Task Specifications (25%)**
- This includes security, observability, and cost-efficiency aspects.
- Ensure that the task requirements are fully met and that the implementation aligns with the specifications provided.

- [ ] **Writing Readable Code (30%)**
- [ ] **Writing Readable Code (20%)**
- Write code that is easy to read and understand.
- Use clear and meaningful variable names, and include comments where necessary.

Expand Down
4 changes: 2 additions & 2 deletions charts/superstream/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.20
version: 0.1.21
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "1.0.703"
appVersion: "1.0.803"
icon: https://memphis-public-files.s3.eu-central-1.amazonaws.com/superstream_logo.png
dependencies:
- name: nats
Expand Down
2 changes: 1 addition & 1 deletion charts/superstream/templates/deployment-control-plane.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ spec:
- name: DB_MAX_CONNS
value: "100"
- name: CH_HOST
value: hr72spwylm.us-east-1.aws.clickhouse.cloud:8443
value: hr72spwylm.us-east-1.aws.clickhouse.cloud:{{ if .Values.global.proxy.enabled }}8443{{ else }}9440{{ end }}
- name: CH_DATABASE
value: superstream_prod_db
- name: CH_USERNAME
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "superstream.fullname" . }}-control-plane-ui
name: {{ include "superstream.fullname" . }}-ui
labels:
{{- include "superstream.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.superstreamControlPlane.userInterface.replicaCount }}
selector:
matchLabels:
{{- include "superstream.selectorLabels" . | nindent 6 }}-control-plane-ui
{{- include "superstream.selectorLabels" . | nindent 6 }}-ui
strategy:
rollingUpdate:
maxSurge: 25%
Expand All @@ -20,9 +20,9 @@ spec:
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
labels:
{{- include "superstream.labels" . | nindent 8 }}
{{- include "superstream.selectorLabels" . | nindent 8 }}-control-plane-ui
{{- include "superstream.selectorLabels" . | nindent 8 }}-ui
spec:
initContainers:
- name: check-nats-readiness # CHANGE TO CP READINESS
Expand All @@ -41,7 +41,7 @@ spec:
done
nodeSelector: {}
containers:
- name: {{ .Chart.Name }}-control-plane-ui
- name: {{ .Chart.Name }}-ui
{{ include "superstream.image" (merge (pick $.Values "global") .Values.superstreamControlPlane.userInterface.image) | nindent 10 }}
securityContext:
{{- toYaml .Values.superstreamEngine.securityContext | nindent 12 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: Service
metadata:
name: {{ include "superstream.fullname" . }}-control-plane-ui
name: {{ include "superstream.fullname" . }}-ui
labels:
{{- include "superstream.labels" . | nindent 4 }}
spec:
Expand All @@ -13,5 +13,5 @@ spec:
protocol: TCP
name: ui
selector:
{{- include "superstream.selectorLabels" . | nindent 4 }}-control-plane-ui
{{- include "superstream.selectorLabels" . | nindent 4 }}-ui
{{- end }}
14 changes: 7 additions & 7 deletions charts/superstream/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ superstreamControlPlane:
# Policy for pulling the image
pullPolicy: Always
# Overrides the image tag whose default is the chart appVersion.
tag: "1.0.703"
tag: "1.0.803"
registry:
imagePullSecrets: []
initContainers:
Expand All @@ -91,11 +91,11 @@ superstreamControlPlane:
replicaCount: 1
image:
# Docker image repository for the UI service
repository: superstreamlabs/superstream-control-plane-onprem-ui
repository: superstreamlabs/superstream-onprem-ui
# Policy for pulling the image
pullPolicy: Always
# Overrides the image tag whose default is the chart appVersion.
tag: "1.0.701"
tag: "1.0.804"
registry:
imagePullSecrets: []
initContainers:
Expand All @@ -108,7 +108,7 @@ superstreamControlPlane:
service:
enabled: true
type: ClusterIP
port: 80
port: 3000
############################################################
# Superstream Engine config
############################################################
Expand All @@ -122,7 +122,7 @@ superstreamEngine:
# Policy for pulling the image
pullPolicy: Always
# Overrides the image tag whose default is the chart appVersion.
tag: "1.0.700"
tag: "1.0.800"
registry:
imagePullSecrets: []
# Overrides for Helm's default naming conventions
Expand Down Expand Up @@ -194,7 +194,7 @@ superstreamEngine:
memory: 8Gi
requests:
cpu: '50m'
memory: 50Mi
memory: 128Mi
# Autoscaling configuration for dynamically adjusting the number of pod replicas
autoscaling:
enabled: true
Expand Down Expand Up @@ -230,7 +230,7 @@ autoScaler:
# Policy for pulling the image
pullPolicy: Always
# Overrides the image tag whose default is the chart appVersion.
tag: "1.0.703"
tag: "1.0.803"
podAnnotations:
prometheus.io/path: "/monitoring/metrics"
prometheus.io/scrape: 'true'
Expand Down
2 changes: 1 addition & 1 deletion version.conf
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.1.20
0.1.21

0 comments on commit e49dfed

Please sign in to comment.