Release 1.0.1 #925

plebhash · 2024-05-23T14:54:33Z

Global Release v1.0.1.

PR Changelog

Crate Version changes

`protocols`

framing-sv2: v1.0.0 → v1.1.0
codec-sv2: v1.0.1 → v1.1.0
roles-logic-sv2: v1.0.0 → v1.1.0

`roles`

jd-client: v0.1.0 → 0.1.1
jd-server: v0.1.0 → v0.1.1
mining-proxy: v0.1.0 → v0.1.1
pool: v0.1.0 → v0.1.1
translator: v0.1.0 → v0.1.1
roles-utils/network-helpers: v0.1.0 → v2.0.0

`utils`

key-utils: v1.0.0 → v1.1.0

Add a nicer user interface to the sv2 cpuminer with help messages. Add noise to the cpuminer.

When the remote peer try to open an encrypted sv2 connection and then immediatly close the tcp connection, the helper for async std and tokio it panic, mostly of the time we don't want to panic in this situation. This commit add an error for this case and return it.

Co-authored-by: fi3 <[email protected]>

github-actions · 2024-05-23T14:58:47Z

Bencher

Report	Mon, May 27, 2024 at 14:47:18 UTC
Project	Stratum v2 (SRI)
Branch	dev
Testbed	sv2

Click to view all benchmark results

Benchmark	Estimated Cycles	Estimated Cycles Results estimated cycles \| (Δ%)	Estimated Cycles Upper Boundary estimated cycles \| (%)	Instructions	Instructions Results instructions \| (Δ%)	Instructions Upper Boundary instructions \| (%)	L1 Accesses	L1 Accesses Results accesses \| (Δ%)	L1 Accesses Upper Boundary accesses \| (%)	L2 Accesses	L2 Accesses Results accesses \| (Δ%)	L2 Accesses Upper Boundary accesses \| (%)	RAM Accesses	RAM Accesses Results accesses \| (Δ%)	RAM Accesses Upper Boundary accesses \| (%)
client_sv2_handle_message_common	✅ (view plot)	2,065.00 (+0.87%)	2,127.59 (97.06%)	✅ (view plot)	473.00 (+0.54%)	487.09 (97.11%)	✅ (view plot)	735.00 (+0.40%)	756.55 (97.15%)	✅ (view plot)	7.00 (+2.75%)	10.25 (68.28%)	✅ (view plot)	37.00 (+1.08%)	38.61 (95.82%)
client_sv2_handle_message_mining	✅ (view plot)	8,203.00 (+0.10%)	8,341.00 (98.35%)	✅ (view plot)	2,137.00 (+0.52%)	2,172.34 (98.37%)	✅ (view plot)	3,163.00 (+0.65%)	3,217.69 (98.30%)	✅ (view plot)	35.00 (-9.48%)	43.61 (80.26%)	✅ (view plot)	139.00 (+0.14%)	142.11 (97.81%)
client_sv2_mining_message_submit_standard	✅ (view plot)	6,242.00 (-0.56%)	6,395.97 (97.59%)	✅ (view plot)	1,750.00 (+0.03%)	1,764.04 (99.20%)	✅ (view plot)	2,557.00 (+0.12%)	2,577.30 (99.21%)	✅ (view plot)	16.00 (-8.02%)	22.40 (71.43%)	✅ (view plot)	103.00 (-0.86%)	107.13 (96.15%)
client_sv2_mining_message_submit_standard_serialize	✅ (view plot)	14,825.00 (+0.35%)	15,043.64 (98.55%)	✅ (view plot)	4,694.00 (+0.01%)	4,708.04 (99.70%)	✅ (view plot)	6,755.00 (+0.01%)	6,776.75 (99.68%)	✅ (view plot)	46.00 (-2.43%)	51.85 (88.72%)	✅ (view plot)	224.00 (+0.73%)	230.24 (97.29%)
client_sv2_mining_message_submit_standard_serialize_deserialize	✅ (view plot)	27,522.00 (+0.18%)	27,860.27 (98.79%)	✅ (view plot)	10,545.00 (+0.04%)	10,559.15 (99.87%)	✅ (view plot)	15,342.00 (+0.02%)	15,361.99 (99.87%)	✅ (view plot)	84.00 (+0.45%)	89.31 (94.06%)	✅ (view plot)	336.00 (+0.37%)	345.80 (97.17%)
client_sv2_open_channel	✅ (view plot)	4,527.00 (+0.80%)	4,613.26 (98.13%)	✅ (view plot)	1,461.00 (+0.06%)	1,475.30 (99.03%)	✅ (view plot)	2,152.00 (-0.03%)	2,174.18 (98.98%)	✅ (view plot)	13.00 (+9.09%)	15.28 (85.08%)	✅ (view plot)	66.00 (+1.38%)	68.22 (96.74%)
client_sv2_open_channel_serialize	✅ (view plot)	14,262.00 (+0.32%)	14,465.48 (98.59%)	✅ (view plot)	5,064.00 (+0.02%)	5,078.30 (99.72%)	✅ (view plot)	7,317.00 (-0.01%)	7,340.68 (99.68%)	✅ (view plot)	38.00 (+2.36%)	41.62 (91.30%)	✅ (view plot)	193.00 (+0.62%)	198.97 (97.00%)
client_sv2_open_channel_serialize_deserialize	✅ (view plot)	22,700.00 (+0.29%)	23,037.78 (98.53%)	✅ (view plot)	7,987.00 (+0.05%)	8,001.71 (99.82%)	✅ (view plot)	11,615.00 (+0.02%)	11,637.95 (99.80%)	✅ (view plot)	75.00 (+2.80%)	81.45 (92.08%)	✅ (view plot)	306.00 (+0.49%)	315.33 (97.04%)
client_sv2_setup_connection	✅ (view plot)	4,699.00 (+0.00%)	4,768.72 (98.54%)	✅ (view plot)	1,502.00 (+0.06%)	1,516.30 (99.06%)	✅ (view plot)	2,279.00 (+0.10%)	2,301.13 (99.04%)	✅ (view plot)	8.00 (-11.32%)	13.34 (59.96%)	✅ (view plot)	68.00 (+0.12%)	69.69 (97.58%)
client_sv2_setup_connection_serialize	✅ (view plot)	16,372.00 (+0.67%)	16,475.71 (99.37%)	✅ (view plot)	5,963.00 (+0.01%)	5,977.30 (99.76%)	✅ (view plot)	8,652.00 (-0.04%)	8,678.98 (99.69%)	✅ (view plot)	46.00 (+3.56%)	48.70 (94.45%)	✅ (view plot)	214.00 (+1.40%)	217.00 (98.62%)
client_sv2_setup_connection_serialize_deserialize	✅ (view plot)	35,608.00 (+0.22%)	35,749.56 (99.60%)	✅ (view plot)	14,814.00 (+0.03%)	14,828.71 (99.90%)	✅ (view plot)	21,748.00 (-0.01%)	21,773.86 (99.88%)	✅ (view plot)	105.00 (+6.08%)	112.09 (93.68%)	✅ (view plot)	381.00 (+0.37%)	384.46 (99.10%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

github-actions · 2024-05-23T14:58:47Z

Bencher

Report	Mon, May 27, 2024 at 14:47:14 UTC
Project	Stratum v2 (SRI)
Branch	dev
Testbed	sv2

🚨 1 ALERT: Threshold Boundary Limit exceeded!

Benchmark	Measure (units)	View	Value	Lower Boundary	Upper Boundary
client_sv2_mining_message_submit_standard_serialize_deserialize	Latency (nanoseconds (ns))	🚨 (view plot \| view alert)	646.81 (+8.74%)		630.06 (102.66%)

Click to view all benchmark results

Benchmark	Latency	Latency Results nanoseconds (ns) \| (Δ%)	Latency Upper Boundary nanoseconds (ns) \| (%)
client_sv2_handle_message_common	✅ (view plot)	44.46 (-0.18%)	45.24 (98.28%)
client_sv2_handle_message_mining	✅ (view plot)	75.05 (+3.36%)	80.39 (93.36%)
client_sv2_mining_message_submit_standard	✅ (view plot)	14.63 (-0.13%)	14.69 (99.63%)
client_sv2_mining_message_submit_standard_serialize	✅ (view plot)	262.88 (-0.61%)	284.79 (92.31%)
client_sv2_mining_message_submit_standard_serialize_deserialize	🚨 (view plot \| view alert)	646.81 (+8.74%)	630.06 (102.66%)
client_sv2_open_channel	✅ (view plot)	166.66 (+0.58%)	171.48 (97.19%)
client_sv2_open_channel_serialize	✅ (view plot)	279.03 (-1.57%)	293.46 (95.08%)
client_sv2_open_channel_serialize_deserialize	✅ (view plot)	371.98 (-1.03%)	402.38 (92.45%)
client_sv2_setup_connection	✅ (view plot)	163.63 (-0.41%)	175.41 (93.29%)
client_sv2_setup_connection_serialize	✅ (view plot)	465.93 (-1.77%)	503.02 (92.63%)
client_sv2_setup_connection_serialize_deserialize	✅ (view plot)	929.40 (-4.39%)	1,040.94 (89.28%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

github-actions · 2024-05-23T14:58:47Z

Bencher

Report	Mon, May 27, 2024 at 14:47:17 UTC
Project	Stratum v2 (SRI)
Branch	dev
Testbed	sv1

Click to view all benchmark results

Benchmark	Estimated Cycles	Estimated Cycles Results estimated cycles \| (Δ%)	Estimated Cycles Upper Boundary estimated cycles \| (%)	Instructions	Instructions Results instructions \| (Δ%)	Instructions Upper Boundary instructions \| (%)	L1 Accesses	L1 Accesses Results accesses \| (Δ%)	L1 Accesses Upper Boundary accesses \| (%)	L2 Accesses	L2 Accesses Results accesses \| (Δ%)	L2 Accesses Upper Boundary accesses \| (%)	RAM Accesses	RAM Accesses Results accesses \| (Δ%)	RAM Accesses Upper Boundary accesses \| (%)
get_authorize	✅ (view plot)	8,515.00 (+1.05%)	8,731.96 (97.52%)	✅ (view plot)	3,772.00 (+0.92%)	3,859.74 (97.73%)	✅ (view plot)	5,295.00 (+1.04%)	5,406.43 (97.94%)	✅ (view plot)	7.00 (-13.18%)	10.52 (66.56%)	✅ (view plot)	91.00 (+1.25%)	94.02 (96.78%)
get_submit	✅ (view plot)	95,618.00 (+0.07%)	96,183.44 (99.41%)	✅ (view plot)	59,522.00 (+0.09%)	59,798.46 (99.54%)	✅ (view plot)	85,493.00 (+0.11%)	85,862.26 (99.57%)	✅ (view plot)	58.00 (+5.33%)	62.35 (93.03%)	✅ (view plot)	281.00 (-0.41%)	288.16 (97.51%)
get_subscribe	✅ (view plot)	8,020.00 (+0.59%)	8,287.82 (96.77%)	✅ (view plot)	2,848.00 (+0.72%)	2,945.46 (96.69%)	✅ (view plot)	3,980.00 (+0.74%)	4,106.71 (96.91%)	✅ (view plot)	17.00 (+5.43%)	19.51 (87.14%)	✅ (view plot)	113.00 (+0.33%)	117.24 (96.38%)
serialize_authorize	✅ (view plot)	12,336.00 (+1.17%)	12,501.89 (98.67%)	✅ (view plot)	5,343.00 (+0.65%)	5,430.74 (98.38%)	✅ (view plot)	7,456.00 (+0.71%)	7,570.13 (98.49%)	✅ (view plot)	10.00 (-8.22%)	13.53 (73.93%)	✅ (view plot)	138.00 (+1.99%)	140.04 (98.54%)
serialize_deserialize_authorize	✅ (view plot)	24,550.00 (+0.36%)	24,709.94 (99.35%)	✅ (view plot)	9,950.00 (+0.55%)	10,028.49 (99.22%)	✅ (view plot)	14,050.00 (+0.64%)	14,152.05 (99.28%)	✅ (view plot)	35.00 (-5.08%)	41.90 (83.54%)	✅ (view plot)	295.00 (+0.08%)	297.63 (99.12%)
serialize_deserialize_handle_authorize	✅ (view plot)	30,176.00 (+0.12%)	30,341.49 (99.45%)	✅ (view plot)	12,127.00 (+0.29%)	12,214.74 (99.28%)	✅ (view plot)	17,166.00 (+0.31%)	17,286.06 (99.31%)	✅ (view plot)	61.00 (+4.31%)	64.38 (94.76%)	✅ (view plot)	363.00 (-0.23%)	366.77 (98.97%)
serialize_deserialize_handle_submit	✅ (view plot)	126,465.00 (+0.04%)	127,076.07 (99.52%)	✅ (view plot)	73,307.00 (+0.08%)	73,644.30 (99.54%)	✅ (view plot)	105,085.00 (+0.10%)	105,544.13 (99.56%)	✅ (view plot)	125.00 (+4.13%)	131.13 (95.33%)	✅ (view plot)	593.00 (-0.33%)	599.47 (98.92%)
serialize_deserialize_handle_subscribe	✅ (view plot)	27,446.00 (-0.03%)	27,611.72 (99.40%)	✅ (view plot)	9,650.00 (+0.21%)	9,747.46 (99.00%)	✅ (view plot)	13,646.00 (+0.19%)	13,783.34 (99.00%)	✅ (view plot)	72.00 (+9.68%)	73.17 (98.40%)	✅ (view plot)	384.00 (-0.50%)	388.57 (98.82%)
serialize_deserialize_submit	✅ (view plot)	115,245.00 (+0.15%)	115,678.95 (99.62%)	✅ (view plot)	68,167.00 (+0.17%)	68,416.89 (99.63%)	✅ (view plot)	97,835.00 (+0.20%)	98,165.95 (99.66%)	✅ (view plot)	73.00 (+5.42%)	74.63 (97.82%)	✅ (view plot)	487.00 (-0.24%)	492.70 (98.84%)
serialize_deserialize_subscribe	✅ (view plot)	22,930.00 (+0.26%)	23,122.01 (99.17%)	✅ (view plot)	8,209.00 (+0.31%)	8,302.77 (98.87%)	✅ (view plot)	11,565.00 (+0.34%)	11,689.41 (98.94%)	✅ (view plot)	40.00 (+1.32%)	44.22 (90.45%)	✅ (view plot)	319.00 (+0.16%)	321.65 (99.18%)
serialize_submit	✅ (view plot)	100,011.00 (+0.12%)	100,504.05 (99.51%)	✅ (view plot)	61,566.00 (+0.09%)	61,848.35 (99.54%)	✅ (view plot)	88,336.00 (+0.10%)	88,716.92 (99.57%)	✅ (view plot)	60.00 (+7.95%)	61.33 (97.83%)	✅ (view plot)	325.00 (+0.10%)	329.51 (98.63%)
serialize_subscribe	✅ (view plot)	11,417.00 (+0.86%)	11,615.09 (98.29%)	✅ (view plot)	4,195.00 (+0.49%)	4,292.46 (97.73%)	✅ (view plot)	5,837.00 (+0.48%)	5,966.26 (97.83%)	✅ (view plot)	17.00 (+4.62%)	18.67 (91.06%)	✅ (view plot)	157.00 (+1.21%)	159.86 (98.21%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

github-actions · 2024-05-23T14:58:49Z

Bencher

Report	Mon, May 27, 2024 at 14:47:17 UTC
Project	Stratum v2 (SRI)
Branch	925/merge
Testbed	sv1

Click to view all benchmark results

Benchmark	Latency	Latency Results nanoseconds (ns) \| (Δ%)	Latency Upper Boundary nanoseconds (ns) \| (%)
client-submit-serialize	✅ (view plot)	7,206.90 (+3.96%)	7,274.06 (99.08%)
client-submit-serialize-deserialize	✅ (view plot)	8,132.10 (+3.57%)	8,261.06 (98.44%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle	✅ (view plot)	8,575.70 (+1.77%)	8,806.01 (97.38%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle	✅ (view plot)	885.89 (-1.26%)	924.53 (95.82%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize	✅ (view plot)	683.91 (-1.74%)	717.03 (95.38%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize	✅ (view plot)	245.52 (-0.94%)	254.12 (96.62%)
client-sv1-get-authorize/client-sv1-get-authorize	✅ (view plot)	156.46 (-0.24%)	159.94 (97.82%)
client-sv1-get-submit	✅ (view plot)	6,915.00 (+3.51%)	7,036.11 (98.28%)
client-sv1-get-subscribe/client-sv1-get-subscribe	✅ (view plot)	272.75 (-2.06%)	290.64 (93.85%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle	✅ (view plot)	736.27 (-1.61%)	779.04 (94.51%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize	✅ (view plot)	607.59 (-1.17%)	637.73 (95.27%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize	✅ (view plot)	206.79 (+0.00%)	219.63 (94.15%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

GitGab19

ACK

This reverts commit 19d6221.

fi3 and others added 30 commits May 3, 2024 12:15

Improve sv2 cpuminer

5b856a8

Add a nicer user interface to the sv2 cpuminer with help messages. Add noise to the cpuminer.

Add user identifier as cli arg

2c6fc33

Add hashrate estimation for cpuminer

9dd78b0

Fix fmt and clippy

8f1d849

Translators readme (#805)

cd7d420

modified the README in roles/pool dir (#802)

a94ac34

JD Client README file retouched (#800)

062edbc

Fix typo

2ecc9cb

Improve sv2 cpuminer

1e4552e

Add a nicer user interface to the sv2 cpuminer with help messages. Add noise to the cpuminer.

Fix fmt and clippy

51e14f9

Update proxy-config-example.toml

71443c8

Update pool-config-local-tp-example.toml

7ca9fbc

Update tproxy-config-local-jdc-example.toml

821a0e0

Update tproxy-config-local-pool-example.toml

00a2038

Fix roles add error en no config file

8981a25

Fix tproxy panic when no config

f2913e8

Add support for ARM binaries

214b227

Add sha256 dep

f951edd

Bump network helpers version

c7cf4f5

chore: refactor update_mempool function in the jds mempool

fd485c2

fix error handling

b46355b

Fix deprecation notice on CI (#879)

2aa71f1

Fix cpu miner hashrate measurement (#866)

5e48904

Co-authored-by: fi3 <[email protected]>

run benchmarks on dev PRs (#898)

0b13191

docs framing_sv2 (#848)

a803f1a

better import for libsecp256k1 (#894)

73a7850

tproxy-config-hosted-pool-example (#875)

7bbffd4

Fix cpu miner panic when not header (#908)

bd494af

Co-authored-by: fi3 <[email protected]>

Discard old ProvideMissingTransactionsSuccess messages in JDS (#900)

eea5655

patch RELEASE.md (#924)

c8424b6

plebhash closed this May 23, 2024

This was referenced May 23, 2024

patch check-versioning-lib-release.sh #926

Merged

bump codec sv2 version #927

Merged

patch check-versioning-lib-release.sh (#926)

296938a

plebhash reopened this May 23, 2024

plebhash marked this pull request as draft May 23, 2024 18:33

bump codec_sv2 version (#927)

d432fa8

plebhash mentioned this pull request May 23, 2024

print version changes on check-versioning-lib-release.sh #929

Merged

pavlenex linked an issue May 24, 2024 that may be closed by this pull request

new Release #880

Closed

pavlenex added this to the 1.0.1 milestone May 24, 2024

pavlenex assigned plebhash May 24, 2024

plebhash added 2 commits May 24, 2024 15:40

improve check-versioning-lib-release (#929)

87f60ec

bump crate versions for release (#930)

5fef39e

plebhash marked this pull request as ready for review May 24, 2024 19:21

plebhash requested review from GitGab19, Fi3 and pavlenex May 24, 2024 19:37

GitGab19 approved these changes May 25, 2024

View reviewed changes

plebhash mentioned this pull request May 25, 2024

Update Cargo.lock files with version updates #933

Merged

plebhash added the release Important for upcoming release label May 27, 2024

Update Cargo.lock files with version updates (#933)

d613473

pavlenex approved these changes May 27, 2024

View reviewed changes

plebhash removed the request for review from Fi3 May 27, 2024 16:14

plebhash merged commit 19d6221 into main May 27, 2024
23 checks passed

Fi3 added a commit that referenced this pull request May 28, 2024

Revert "Release 1.0.1 (#925)"

87fc63d

This reverts commit 19d6221.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.0.1 #925

Release 1.0.1 #925

plebhash commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

GitGab19 left a comment

Release 1.0.1 #925

Release 1.0.1 #925

Conversation

plebhash commented May 23, 2024 • edited Loading

PR Changelog

Crate Version changes

protocols

roles

utils

github-actions bot commented May 23, 2024 • edited Loading

Bencher

github-actions bot commented May 23, 2024 • edited Loading

Bencher

github-actions bot commented May 23, 2024 • edited Loading

Bencher

github-actions bot commented May 23, 2024 • edited Loading

Bencher

GitGab19 left a comment

Choose a reason for hiding this comment

plebhash commented May 23, 2024 •

edited

Loading

`protocols`

`roles`

`utils`

github-actions bot commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading