Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch check-versioning-lib-release.sh #926

Merged

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented May 23, 2024

while preparing Release v1.0.1 (#925), I noticed that check-versioning-lib-release.sh wasn't working as expected

basically, the git diff command couldn't find the correct branches to compare:
https://github.com/stratum-mining/stratum/actions/runs/9210253269/job/25336804115#step:3:1

so I had to make some modifications to the script, which now seems to work correctly on a mock PR on my fork:
https://github.com/plebhash/stratum/actions/runs/9211103745/job/25339668933#step:3:1

as the action above indicates, we also need to bump version on codec_sv2, which is being done via #927

Copy link
Contributor

🐰Bencher

ReportThu, May 23, 2024 at 16:03:54 UTC
ProjectStratum v2 (SRI)
Branchpatch-check-versioning-lib-release.sh
Testbedsv1

🚨 3 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_deserialize_handle_authorizeL2 Accesses (accesses)🚨 (view plot | view alert)66.00 (+13.38%)64.35 (102.56%)
serialize_deserialize_handle_subscribeL2 Accesses (accesses)🚨 (view plot | view alert)73.00 (+12.43%)71.38 (102.26%)
serialize_subscribeL2 Accesses (accesses)🚨 (view plot | view alert)19.00 (+17.22%)18.86 (100.76%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,478.00 (+0.73%)8,733.83 (97.07%)✅ (view plot)3,746.00 (+0.32%)3,861.52 (97.01%)✅ (view plot)5,248.00 (+0.24%)5,407.47 (97.05%)✅ (view plot)9.00 (+11.85%)10.55 (85.32%)✅ (view plot)91.00 (+1.40%)94.06 (96.75%)
get_submit✅ (view plot)95,579.00 (+0.04%)96,211.46 (99.34%)✅ (view plot)59,439.00 (-0.04%)59,811.97 (99.38%)✅ (view plot)85,349.00 (-0.05%)85,878.43 (99.38%)✅ (view plot)58.00 (+5.72%)62.45 (92.88%)✅ (view plot)284.00 (+0.64%)288.49 (98.44%)
get_subscribe✅ (view plot)8,049.00 (+1.05%)8,295.34 (97.03%)✅ (view plot)2,841.00 (+0.55%)2,949.49 (96.32%)✅ (view plot)3,964.00 (+0.41%)4,111.82 (96.40%)✅ (view plot)19.00 (+18.58%)19.58 (97.05%)✅ (view plot)114.00 (+1.32%)117.34 (97.16%)
serialize_authorize✅ (view plot)12,197.00 (+0.15%)12,487.06 (97.68%)✅ (view plot)5,317.00 (+0.22%)5,432.52 (97.87%)✅ (view plot)7,412.00 (+0.19%)7,571.50 (97.89%)✅ (view plot)12.00 (+9.55%)13.66 (87.87%)✅ (view plot)135.00 (-0.02%)139.54 (96.75%)
serialize_deserialize_authorize✅ (view plot)24,476.00 (+0.11%)24,697.78 (99.10%)✅ (view plot)9,898.00 (+0.07%)10,026.55 (98.72%)✅ (view plot)13,956.00 (+0.03%)14,146.51 (98.65%)✅ (view plot)39.00 (+5.54%)42.14 (92.54%)✅ (view plot)295.00 (+0.13%)297.48 (99.17%)
serialize_deserialize_handle_authorize✅ (view plot)30,219.00 (+0.29%)30,338.40 (99.61%)✅ (view plot)12,101.00 (+0.10%)12,216.52 (99.05%)✅ (view plot)17,114.00 (+0.03%)17,288.07 (98.99%)🚨 (view plot | view alert)66.00 (+13.38%)64.35 (102.56%)✅ (view plot)365.00 (+0.33%)366.81 (99.51%)
serialize_deserialize_handle_submit✅ (view plot)126,472.00 (+0.06%)127,104.25 (99.50%)✅ (view plot)73,224.00 (-0.02%)73,661.17 (99.41%)✅ (view plot)104,937.00 (-0.04%)105,565.36 (99.40%)✅ (view plot)128.00 (+7.04%)130.88 (97.80%)✅ (view plot)597.00 (+0.33%)599.65 (99.56%)
serialize_deserialize_handle_subscribe✅ (view plot)27,539.00 (+0.32%)27,612.75 (99.73%)✅ (view plot)9,643.00 (+0.16%)9,751.49 (98.89%)✅ (view plot)13,629.00 (+0.09%)13,789.68 (98.83%)🚨 (view plot | view alert)73.00 (+12.43%)71.38 (102.26%)✅ (view plot)387.00 (+0.27%)388.62 (99.58%)
serialize_deserialize_submit✅ (view plot)115,069.00 (+0.01%)115,682.35 (99.47%)✅ (view plot)68,001.00 (-0.06%)68,421.21 (99.39%)✅ (view plot)97,549.00 (-0.08%)98,165.18 (99.37%)✅ (view plot)74.00 (+7.28%)74.32 (99.57%)✅ (view plot)490.00 (+0.38%)492.86 (99.42%)
serialize_deserialize_subscribe✅ (view plot)22,916.00 (+0.24%)23,118.49 (99.12%)✅ (view plot)8,195.00 (+0.17%)8,306.03 (98.66%)✅ (view plot)11,536.00 (+0.12%)11,693.40 (98.65%)✅ (view plot)43.00 (+9.15%)44.41 (96.83%)✅ (view plot)319.00 (+0.21%)321.45 (99.24%)
serialize_submit✅ (view plot)99,862.00 (-0.01%)100,520.20 (99.35%)✅ (view plot)61,483.00 (-0.04%)61,862.33 (99.39%)✅ (view plot)88,197.00 (-0.05%)88,734.19 (99.39%)✅ (view plot)58.00 (+4.79%)61.09 (94.94%)✅ (view plot)325.00 (+0.14%)329.55 (98.62%)
serialize_subscribe✅ (view plot)11,344.00 (+0.32%)11,606.78 (97.74%)✅ (view plot)4,188.00 (+0.37%)4,296.49 (97.47%)✅ (view plot)5,824.00 (+0.31%)5,971.63 (97.53%)🚨 (view plot | view alert)19.00 (+17.22%)18.86 (100.76%)✅ (view plot)155.00 (+0.09%)159.44 (97.21%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportThu, May 23, 2024 at 16:03:55 UTC
ProjectStratum v2 (SRI)
Branch926/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,887.90 (-0.55%)7,280.15 (94.61%)
client-submit-serialize-deserialize✅ (view plot)7,886.50 (+0.51%)8,271.12 (95.35%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,429.20 (+0.08%)8,825.54 (95.51%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)913.40 (+1.62%)927.94 (98.43%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)687.03 (-1.38%)718.11 (95.67%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)243.71 (-1.64%)254.40 (95.80%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)156.40 (-0.26%)160.10 (97.69%)
client-sv1-get-submit✅ (view plot)6,540.10 (-2.11%)7,037.28 (92.94%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)282.56 (+1.33%)291.66 (96.88%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)753.94 (+0.88%)776.82 (97.05%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)615.61 (+0.14%)637.96 (96.50%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)204.42 (-1.08%)220.17 (92.85%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportThu, May 23, 2024 at 16:03:56 UTC
ProjectStratum v2 (SRI)
Branchpatch-check-versioning-lib-release.sh
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.42 (-0.23%)45.22 (98.23%)
client_sv2_handle_message_mining✅ (view plot)72.19 (-0.23%)80.34 (89.86%)
client_sv2_mining_message_submit_standard✅ (view plot)14.63 (-0.16%)14.69 (99.59%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)271.10 (+2.26%)286.16 (94.74%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)589.37 (-0.67%)624.48 (94.38%)
client_sv2_open_channel✅ (view plot)165.04 (-0.35%)171.51 (96.23%)
client_sv2_open_channel_serialize✅ (view plot)285.07 (+0.55%)293.62 (97.09%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)377.62 (+0.38%)404.08 (93.45%)
client_sv2_setup_connection✅ (view plot)167.35 (+1.87%)175.84 (95.17%)
client_sv2_setup_connection_serialize✅ (view plot)460.52 (-2.74%)500.32 (92.04%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)906.85 (-6.83%)1,046.20 (86.68%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportThu, May 23, 2024 at 16:03:57 UTC
ProjectStratum v2 (SRI)
Branchpatch-check-versioning-lib-release.sh
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,061.00 (+0.69%)2,130.67 (96.73%)✅ (view plot)473.00 (+0.60%)487.70 (96.99%)✅ (view plot)736.00 (+0.59%)757.49 (97.16%)✅ (view plot)6.00 (-11.64%)10.41 (57.66%)✅ (view plot)37.00 (+1.08%)38.71 (95.59%)
client_sv2_handle_message_mining✅ (view plot)8,203.00 (+0.12%)8,348.16 (98.26%)✅ (view plot)2,137.00 (+0.58%)2,173.13 (98.34%)✅ (view plot)3,163.00 (+0.72%)3,218.51 (98.28%)✅ (view plot)35.00 (-10.26%)43.71 (80.08%)✅ (view plot)139.00 (+0.15%)142.29 (97.69%)
client_sv2_mining_message_submit_standard✅ (view plot)6,246.00 (-0.58%)6,403.18 (97.55%)✅ (view plot)1,750.00 (+0.03%)1,764.85 (99.16%)✅ (view plot)2,556.00 (+0.10%)2,578.32 (99.13%)✅ (view plot)17.00 (-2.53%)22.66 (75.02%)✅ (view plot)103.00 (-1.01%)107.31 (95.98%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,833.00 (+0.42%)15,055.64 (98.52%)✅ (view plot)4,694.00 (+0.01%)4,708.85 (99.68%)✅ (view plot)6,753.00 (-0.02%)6,777.93 (99.63%)✅ (view plot)48.00 (+1.52%)52.21 (91.94%)✅ (view plot)224.00 (+0.77%)230.56 (97.15%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,564.00 (+0.35%)27,876.48 (98.88%)✅ (view plot)10,545.00 (+0.04%)10,559.56 (99.86%)✅ (view plot)15,339.00 (+0.01%)15,362.82 (99.84%)✅ (view plot)86.00 (+2.89%)89.60 (95.98%)✅ (view plot)337.00 (+0.71%)346.28 (97.32%)
client_sv2_open_channel✅ (view plot)4,527.00 (+0.87%)4,615.96 (98.07%)✅ (view plot)1,461.00 (+0.07%)1,476.10 (98.98%)✅ (view plot)2,152.00 (-0.04%)2,175.54 (98.92%)✅ (view plot)13.00 (+10.69%)15.11 (86.06%)✅ (view plot)66.00 (+1.47%)68.31 (96.62%)
client_sv2_open_channel_serialize✅ (view plot)14,262.00 (+0.35%)14,474.60 (98.53%)✅ (view plot)5,064.00 (+0.02%)5,079.10 (99.70%)✅ (view plot)7,317.00 (-0.01%)7,342.14 (99.66%)✅ (view plot)38.00 (+2.90%)41.37 (91.85%)✅ (view plot)193.00 (+0.67%)199.28 (96.85%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,712.00 (+0.36%)23,054.24 (98.52%)✅ (view plot)7,987.00 (+0.06%)8,002.10 (99.81%)✅ (view plot)11,612.00 (-0.01%)11,639.39 (99.76%)✅ (view plot)78.00 (+7.71%)80.52 (96.87%)✅ (view plot)306.00 (+0.52%)315.87 (96.88%)
client_sv2_setup_connection✅ (view plot)4,699.00 (-0.03%)4,772.77 (98.45%)✅ (view plot)1,502.00 (+0.06%)1,517.10 (99.00%)✅ (view plot)2,279.00 (+0.11%)2,302.28 (98.99%)✅ (view plot)8.00 (-12.02%)13.64 (58.66%)✅ (view plot)68.00 (+0.07%)69.78 (97.45%)
client_sv2_setup_connection_serialize✅ (view plot)16,372.00 (+0.73%)16,464.63 (99.44%)✅ (view plot)5,963.00 (+0.02%)5,978.10 (99.75%)✅ (view plot)8,652.00 (-0.04%)8,680.65 (99.67%)✅ (view plot)46.00 (+4.11%)48.36 (95.13%)✅ (view plot)214.00 (+1.54%)216.74 (98.74%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,604.00 (+0.22%)35,751.59 (99.59%)✅ (view plot)14,814.00 (+0.03%)14,829.10 (99.90%)✅ (view plot)21,749.00 (-0.00%)21,775.20 (99.88%)✅ (view plot)104.00 (+5.55%)112.05 (92.81%)✅ (view plot)381.00 (+0.40%)384.52 (99.08%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@plebhash plebhash mentioned this pull request May 23, 2024
@pavlenex pavlenex added this to the 1.0.1 milestone May 23, 2024
@pavlenex pavlenex requested a review from Fi3 May 23, 2024 17:19
@plebhash plebhash merged commit 296938a into stratum-mining:dev May 23, 2024
13 checks passed
@plebhash plebhash deleted the patch-check-versioning-lib-release.sh branch May 23, 2024 18:07
@plebhash plebhash mentioned this pull request May 23, 2024
Fi3 pushed a commit that referenced this pull request May 28, 2024
@plebhash plebhash mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

4 participants