-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Prerelease 8.5.0-beta.5 #30124
Open
github-actions
wants to merge
25
commits into
next-release
Choose a base branch
from
version-non-patch-from-8.5.0-beta.4
base: next-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+309
−159
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
13e3869
React: Use Act wrapper in Storybook for component rendering
valentinpalkovic 5a278d5
Merge remote-tracking branch 'origin/next' into valentin/act-wrapping…
valentinpalkovic 9ea0238
Update act implementation for production environment and adjust NODE_…
valentinpalkovic 126f504
Merge remote-tracking branch 'origin/next' into valentin/act-wrapping…
valentinpalkovic a52aec2
Apply NODE_ENV development for react-based projects
valentinpalkovic 3aca753
Merge branch 'next' into valentin/act-wrapping-of-components
valentinpalkovic 4bfde81
fix node-logger ESM export
JReinhold 684b18f
Merge branch 'next' into jeppe/fix-node-logger
JReinhold d59d47b
Merge branch 'next' into valentin/act-wrapping-of-components
valentinpalkovic 8719f06
Switch orders of stories
valentinpalkovic 3a65dab
Merge remote-tracking branch 'origin/next' into valentin/act-wrapping…
valentinpalkovic 4bf0f02
Add developmentModeForBuild feature and update NODE_ENV handling
valentinpalkovic 2653516
Fix develop mode handling
valentinpalkovic 45971d9
Refactor development mode handling in Vite build configuration
valentinpalkovic 4f0864d
Merge remote-tracking branch 'origin/next' into valentin/act-wrapping…
valentinpalkovic 037e928
Merge branch 'next' into valentin/act-wrapping-of-components
valentinpalkovic 0203747
Add documentation
valentinpalkovic 9e94c25
Refactor Button and Header components to use not use React's defaultP…
valentinpalkovic 7a5ca27
Clarify ts-expect-error comment in webpack preset configuration
valentinpalkovic 4d708a0
Add conditional plugin configuration for development mode in webpack …
valentinpalkovic d7b2b34
Update docs/writing-tests/accessibility-testing.mdx
valentinpalkovic b0737e7
Update docs/api/main-config/main-config-features.mdx
valentinpalkovic c706998
Merge pull request #30037 from storybookjs/valentin/act-wrapping-of-c…
valentinpalkovic f4e6a50
Merge pull request #30093 from storybookjs/jeppe/fix-node-logger
JReinhold 421fa8e
Write changelog for 8.5.0-beta.5 [skip ci]
storybook-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,8 @@ import { dirname, join } from 'node:path'; | |
|
||
import type { PresetProperty } from 'storybook/internal/types'; | ||
|
||
import { WebpackDefinePlugin } from '@storybook/builder-webpack5'; | ||
|
||
import type { StorybookConfig } from './types'; | ||
|
||
const getAbsolutePath = <I extends string>(input: I): I => | ||
|
@@ -24,12 +26,23 @@ export const core: PresetProperty<'core'> = async (config, options) => { | |
}; | ||
}; | ||
|
||
export const webpack: StorybookConfig['webpack'] = async (config) => { | ||
export const webpack: StorybookConfig['webpack'] = async (config, options) => { | ||
config.resolve = config.resolve || {}; | ||
|
||
config.resolve.alias = { | ||
...config.resolve?.alias, | ||
'@storybook/react': getAbsolutePath('@storybook/react'), | ||
}; | ||
|
||
if (options.features?.developmentModeForBuild) { | ||
config.plugins = [ | ||
// @ts-expect-error Ignore this error, because in the `webpack` preset the user actually hasn't defined a config yet. | ||
...config.plugins, | ||
Comment on lines
+39
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Spreading undefined plugins will cause runtime error if config.plugins is not initialized |
||
new WebpackDefinePlugin({ | ||
NODE_ENV: JSON.stringify('development'), | ||
}), | ||
]; | ||
} | ||
|
||
return config; | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing type assertion on config.build assignment could cause type errors