Release: Prerelease 8.5.0-beta.5 #30124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ENV handling in build scripts
- Introduced a new feature flag `developmentModeForBuild` to enhance testability in built Storybooks. - Updated build configurations to set `process.env.NODE_ENV` to `development` when the feature is enabled. - Cleaned up unnecessary definitions in various preset and configuration files.
Co-authored-by: Kyle Gach <[email protected]>
Co-authored-by: Kyle Gach <[email protected]>
…omponents React: Use Act wrapper in Storybook for component rendering
github-actions
bot
added
the
release
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
23 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -35,9 +35,22 @@ export async function build(options: Options) { | |||
| } | |||
| : {}), | |||
| }, | |||
| }).build; | |||
| } as InlineConfig).build; | |||
There was a problem hiding this comment.
logic: Missing type assertion on config.build assignment could cause type errors
Comment on lines
+39
to
+40
| // @ts-expect-error Ignore this error, because in the `webpack` preset the user actually hasn't defined a config yet. | ||
| ...config.plugins, |
There was a problem hiding this comment.
logic: Spreading undefined plugins will cause runtime error if config.plugins is not initialized
Comment on lines
+54
to
+57
| if (jestFakeTimersAreEnabled()) { | ||
| // @ts-expect-error global jest | ||
| jest.advanceTimersByTime(0); | ||
| } |
There was a problem hiding this comment.
style: Consider using a more type-safe approach for Jest timer detection instead of @ts-expect-error
Comment on lines
+65
to
+72
| eventWrapper: (cb) => { | ||
| let result; | ||
| act(() => { | ||
| result = cb(); | ||
| return result; | ||
| }); | ||
| return result; | ||
| }, |
There was a problem hiding this comment.
logic: eventWrapper does not handle async events - could cause issues with async event handlers
Core: Fix `ERR_PACKAGE_PATH_NOT_EXPORTED` in `@storybook/node-logger`
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-beta.4
branch
from
ecd0dd9 to
421fa8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.0-beta.4to8.5.0-beta.5.Once this pull request is merged, it will trigger a new release of version
8.5.0-beta.5.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:ERR_PACKAGE_PATH_NOT_EXPORTEDin@storybook/node-logger#30093If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-beta.5
ERR_PACKAGE_PATH_NOT_EXPORTEDin@storybook/node-logger- #30093, thanks @JReinhold!