Move bit_reverse function to backend/cpu #929
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #929 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 94 94
Lines 13731 13731
Branches 13731 13731
=======================================
Hits 12561 12561
Misses 1055 1055
Partials 115 115 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: ef3a094 | Previous: cd8b37b | Ratio |
|---|---|---|---|
iffts/simd ifft/22 |
13036556 ns/iter (± 145281) |
6306399 ns/iter (± 210024) |
2.07 |
merkle throughput/simd merkle |
29901325 ns/iter (± 532223) |
13712527 ns/iter (± 579195) |
2.18 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
There was a problem hiding this comment.
Reviewable status:
Gali-StarkWare
changed the base branch from
Gali_-_Delete_shifted_secure_combination_function
to
graphite-base/929
Gali-StarkWare
force-pushed
the
12-10-move_bit_reverse_function_to_backend_cpu
branch
from
3a00ffe to
ef3a094
Compare
No description provided.