-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gali - Delete shifted_secure_combination Function #928
Gali - Delete shifted_secure_combination Function #928
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
54b5c10
to
de223b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #928 +/- ##
==========================================
+ Coverage 91.46% 91.59% +0.13%
==========================================
Files 94 94
Lines 13712 13870 +158
Branches 13712 13870 +158
==========================================
+ Hits 12541 12704 +163
+ Misses 1056 1050 -6
- Partials 115 116 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: de223b0 | Previous: cd8b37b | Ratio |
---|---|---|---|
iffts/simd ifft/21 |
6496899 ns/iter (± 75110 ) |
3044114 ns/iter (± 156865 ) |
2.13 |
iffts/simd ifft/22 |
14016775 ns/iter (± 145724 ) |
6306399 ns/iter (± 210024 ) |
2.22 |
iffts/simd ifft/27 |
629699578 ns/iter (± 11343629 ) |
312588285 ns/iter (± 9816879 ) |
2.01 |
merkle throughput/simd merkle |
29424426 ns/iter (± 388621 ) |
13712527 ns/iter (± 579195 ) |
2.15 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Gali-StarkWare)
No description provided.