Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gali - Delete shifted_secure_combination Function #928

Merged

Conversation

Gali-StarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Gali-StarkWare commented Dec 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review December 10, 2024 07:19
@Gali-StarkWare Gali-StarkWare self-assigned this Dec 10, 2024
@Gali-StarkWare Gali-StarkWare force-pushed the Gali_-_Delete_shifted_secure_combination_function branch from 54b5c10 to de223b0 Compare December 10, 2024 07:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (2798020) to head (de223b0).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #928      +/-   ##
==========================================
+ Coverage   91.46%   91.59%   +0.13%     
==========================================
  Files          94       94              
  Lines       13712    13870     +158     
  Branches    13712    13870     +158     
==========================================
+ Hits        12541    12704     +163     
+ Misses       1056     1050       -6     
- Partials      115      116       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: de223b0 Previous: cd8b37b Ratio
iffts/simd ifft/21 6496899 ns/iter (± 75110) 3044114 ns/iter (± 156865) 2.13
iffts/simd ifft/22 14016775 ns/iter (± 145724) 6306399 ns/iter (± 210024) 2.22
iffts/simd ifft/27 629699578 ns/iter (± 11343629) 312588285 ns/iter (± 9816879) 2.01
merkle throughput/simd merkle 29424426 ns/iter (± 388621) 13712527 ns/iter (± 579195) 2.15

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Gali-StarkWare)

Copy link
Contributor Author

Gali-StarkWare commented Dec 10, 2024

Merge activity

  • Dec 10, 4:14 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 10, 4:14 AM EST: A user merged this pull request with Graphite.

@Gali-StarkWare Gali-StarkWare merged commit 10a3f69 into dev Dec 10, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants