Added add_intermediate and add_secure_intermediate to eval API.

[Alon-Ti]

No description provided.

[reviewable-StarkWare]

This change is 

[Alon-Ti]

• Added add_intermediate and add_secure_intermediate to eval API. #919 👈 (View in Graphite)
• Add safe simplify for expressions that compares random assignments before and after. #918
• Added test for expression simplifier. #908
• Added eval on exprs. #904
• Separated Base and Extension field expressions. #903
• Added From<G> in add_constraint. #901
• Simplify expressions. #894
• Exported shared code to temp variables in ExprEvaluator. #893
• Added total_ and claimed_sums as formal variables in ExprEvaluator. #892
• State machine constraint string. #889
• Expr formatting. #888
• Formal Expr logup variables. #887
• Initialize logups automatically when first used. #879 : 1 other dependent PR (#883 )
• Abstracted eval.write_fracs to eval.add_to_relations. #876
• Added LogupAtRow functionality to EvalAtRow. #875
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.51%. Comparing base (6e7d2aa) to head (5fd3774).

Files with missing lines	Patch %	Lines
crates/prover/src/constraint_framework/mod.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #919   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          94       94           
  Lines       13634    13666   +32     
  Branches    13634    13666   +32     
=======================================
+ Hits        12477    12507   +30     
- Misses       1042     1044    +2     
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite	Current: 5fd3774	Previous: cd8b37b	Ratio
merkle throughput/simd merkle	28492415 ns/iter (± 488757)	13712527 ns/iter (± 579195)	2.08

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

[ohad-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)

---

crates/prover/src/constraint_framework/mod.rs line 122 at r2 (raw file):

    /// Adds a secure intermediate value to the component and returns its value.
    /// Does nothing by default.
    fn add_secure_intermediate(&mut self, val: Self::EF) -> Self::EF {

Suggestion:

extension

[Alon-Ti]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)

---

crates/prover/src/constraint_framework/mod.rs line 122 at r2 (raw file):

    /// Adds a secure intermediate value to the component and returns its value.
    /// Does nothing by default.
    fn add_secure_intermediate(&mut self, val: Self::EF) -> Self::EF {

Done.

[ohad-starkware]

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

[Alon-Ti]

Merge activity

• Dec 3, 8:19 AM EST: A user merged this pull request with Graphite.