Added From<G> in add_constraint.

[Alon-Ti]

No description provided.

[reviewable-StarkWare]

This change is 

[Alon-Ti]

• Added add_intermediate and add_secure_intermediate to eval API. #919
• Add safe simplify for expressions that compares random assignments before and after. #918
• Added test for expression simplifier. #908
• Added eval on exprs. #904
• Separated Base and Extension field expressions. #903
• Added From<G> in add_constraint. #901 👈 (View in Graphite)
• Simplify expressions. #894
• Exported shared code to temp variables in ExprEvaluator. #893
• Added total_ and claimed_sums as formal variables in ExprEvaluator. #892
• State machine constraint string. #889
• Expr formatting. #888
• Formal Expr logup variables. #887
• Initialize logups automatically when first used. #879 : 1 other dependent PR (#883 )
• Abstracted eval.write_fracs to eval.add_to_relations. #876
• Added LogupAtRow functionality to EvalAtRow. #875
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.56%. Comparing base (e4c2d1d) to head (9523340).

Additional details and impacted files

@@                 Coverage Diff                  @@
##           alont/simplify-expr     #901   +/-   ##
====================================================
  Coverage                91.56%   91.56%           
====================================================
  Files                       93       93           
  Lines                    13228    13226    -2     
  Branches                 13228    13226    -2     
====================================================
- Hits                     12112    12111    -1     
+ Misses                    1003     1002    -1     
  Partials                   113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite	Current: 72b28de	Previous: cd8b37b	Ratio
iffts/simd ifft/22	13490628 ns/iter (± 207604)	6306399 ns/iter (± 210024)	2.14
iffts/simd ifft/25	132322847 ns/iter (± 1934509)	65891527 ns/iter (± 1735211)	2.01
merkle throughput/simd merkle	29899871 ns/iter (± 689114)	13712527 ns/iter (± 579195)	2.18

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

[ohad-starkware]

with comment

Reviewed 1 of 5 files at r1, all commit messages.
Reviewable status: 1 of 5 files reviewed, all discussions resolved

---

crates/prover/src/constraint_framework/expr.rs line 403 at r1 (raw file):

    fn add_constraint<G>(&mut self, constraint: G)
    where
        Self::EF: std::ops::Mul<G, Output = Self::EF> + From<G>,

non blocking

Suggestion:

 Self::EF: From<G

[shaharsamocha7]

Reviewed 3 of 5 files at r1, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)

[Alon-Ti]

Merge activity

• Nov 28, 10:29 AM EST: A user merged this pull request with Graphite.