feat: add chain_id to signer config #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated regtest-env with this PR (hirosystems/stacks-regtest-env#49) and confirmed it's working well |
obycode
reviewed
Oct 15, 2024
There was a problem hiding this comment.
I should have realized in my earlier PR that my integration test in nakamoto_integrations.rs did not include the real signers. Can we also add an integration test in testnet/stacks-node/src/tests/signer/v0.rs that uses a custom chain id? Maybe a variant of multiple_miners_with_nakamoto_blocks?
jferrant
approved these changes
Oct 15, 2024
obycode
approved these changes
Oct 15, 2024
jcnelson
approved these changes
Oct 15, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chain_idto signer config #5313This adds an optional
chain_idfield to the signer's config. If present, it is used in the/v3/block_proposalendpoint.