Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain_id to signer config #5313

Closed
hstove opened this issue Oct 14, 2024 · 1 comment · Fixed by #5314
Closed

Add chain_id to signer config #5313

hstove opened this issue Oct 14, 2024 · 1 comment · Fixed by #5314
Assignees
@hstove
Labels
3.0-must locked

Comments

@hstove
Copy link
Contributor

hstove commented Oct 14, 2024

We recently added support for custom chain IDs to the stacks node, but we need it for the signer as well. This is because the signer includes the chain ID when validating a block proposal, and the node rejects it if the chain ID is different.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Oct 14, 2024
@hstove hstove self-assigned this Oct 14, 2024
@hstove hstove mentioned this issue Oct 15, 2024
Merged
@hstove hstove linked a pull request Oct 15, 2024 that will close this issue
feat: add chain_id to signer config #5314
Merged
@hstove hstove moved this from Status: 🆕 New to Status: In Review in Stacks Core Eng Oct 15, 2024
@saralab saralab closed this as completed Oct 21, 2024
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Oct 21, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hstove hstove

Labels
3.0-must locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add chain_id to signer config stacks-network/stacks-core
3 participants
@saralab @hstove @blockstack-devops