Skip to content

fix(tui): add linear search fallback for session update/delete sync #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cedefrespo wants to merge 1 commit into
base: dev
Choose a base branch
from
+18 −0
Open

fix(tui): add linear search fallback for session update/delete sync #5518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/opencode/src/cli/cmd/tui/context/sync.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,17 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
draft.splice(result.index, 1)
}),
)
break
}
// Linear search fallback for sort order edge cases
const linearIndex = store.session.findIndex((s) => s.id === event.properties.info.id)
if (linearIndex !== -1) {
setStore(
"session",
produce((draft) => {
draft.splice(linearIndex, 1)
}),
)
}
break
}
Expand All @@ -157,6 +168,13 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
setStore("session", result.index, reconcile(event.properties.info))
break
}
// Linear search fallback for sort order edge cases
const linearIndex = store.session.findIndex((s) => s.id === event.properties.info.id)
if (linearIndex !== -1) {
setStore("session", linearIndex, reconcile(event.properties.info))
break
}
// Not found, insert at binary search position
setStore(
"session",
produce((draft) => {
Expand Down