fix(tui): add linear search fallback for session update/delete sync #5518
+18
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Binary.searchfails to find a session in the storeProblem
The
session.updatedandsession.deletedevent handlers useBinary.searchto find sessions in the store array. However, the binary search can fail to find sessions when the store array order differs from the expected sort order (e.g., due to timing issues or string comparison edge cases).This causes:
Solution
Add a linear search fallback (
Array.findIndex) whenBinary.searchreturnsfound: false. This ensures the session is found and updated in the UI regardless of array ordering.The fix is minimal and defensive - it only runs the linear search if binary search fails, so there's no performance impact in the normal case.
Testing
Ctrl+X L)Ctrl+R)Fixes #5494
Fixes #3779