This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
Add support for DROP VIEW #860
Open
agarciamontoro
wants to merge
7
commits into
src-d:feature/views
Choose a base branch
from
agarciamontoro:feature.views.drop
base: feature/views
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for DROP VIEW #860
agarciamontoro
wants to merge
7
commits into
src-d:feature/views
from
agarciamontoro:feature.views.drop
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
erizocosmico
suggested changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just two minor things and LGTM
Signed-off-by: Alejandro García Montoro <[email protected]>
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
DROP VIEW
statements, as inAs each view in the statement may come from a different database, I have decided to model the plan as follows:
DropView
, that just contains a list of children of typeSingleDropView
.SingleDropView
implement theDatabaser
interface so the analyzer can resolve the database in each of them.The actual removal of the views happen in the
RowIter
fromDropView
, as we need to:DropView
can be deleted (i.e., they exist or they do not exist but the user has added theIF EXISTS
keyword to the statement)I first started implementing the removal in the
SingleDropView
nodes, but then it was difficult to check that all views could be deleted and then delete them, all in an atomic operation. The final implementation makes this easy with the newDeleteList
fromViewRegistry
.