Add basic VIEWS support. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Trying to make golangcibot happy Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Before, this function read the string containing all the identifiers *and* the separators between them, splitting the string afterwards to retrieve the list. Now, the list of identifiers is built on the go. Signed-off-by: Alejandro García Montoro <[email protected]>
We can discard the error if it was thrown because the view does not exist. But we don't know if the Delete function will throw different errors in the future, so it is safer to discard only the one we are sure about. Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Add VIEWs support
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
Signed-off-by: Alejandro García Montoro <[email protected]>
added 6 commits
November 21, 2019 15:16
zachmu
approved these changes
Nov 25, 2019
sql/parse/parse.go
Outdated
| return nil, ErrUnsupportedSyntax.New(c.ViewExpr) | ||
| } | ||
|
|
||
| queryNode, err := convertSelect(ctx, selectStatement) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically takes src-d/go-mysql-server#860 and adapts it for our sqlparser changes.