Allow to run ssh commands to localhost #105 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Nov 18, 2024
| @@ -163,7 +172,8 @@ public function getExecuteCommand($command): string | |||
|
|
|||
| $commandString = implode(PHP_EOL, $commands); | |||
|
|
|||
| if (in_array($this->host, ['local', 'localhost', '127.0.0.1'])) { | |||
| // Unless local SSH connections are allowed, execute command locally | |||
| if (!$this->allowLocalConnection && in_array($this->host, ['local', 'localhost', '127.0.0.1'])) { | |||
There was a problem hiding this comment.
Could you move this check to a new function called localConnectionsAllowed that returns a boolean?
In that function do not use $$ but make the code as simple as possible by using early returns.
There was a problem hiding this comment.
Alright! But just to make sure I got it: you'd like to move the 2 checks inside this if to a dedicated method ? If so, wouldn't it be doRunCommandLocally(): bool instead ? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to run ssh commands to localhost #105
See #105 : for testing reasons, one could want to test a set of SSH commands to a local Docker container.
For this purpose, I'm suggesting the option
$allowLocalConnection, by default remains set tofalse. It can be set using the truey only setterallowLocalConnection(). Iftrue, the check on local host that keeps the$commandas a local one is disabled.