Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run ssh commands to localhost #561

Closed

Conversation

pierrelemee
Copy link

Allow to run ssh commands to localhost

See #532 : my wish here is to allow anyone who, like me, would like to test a set of SSH commands over a local Docker container. For this reason, it's handy to explicitly declare an allow_local_connection to the SSH options. Under the hood, this takes advantage of the spatie Ssh option I'm currently suggesting there.

Note

I also included a fix to the buildSssh() function so that boolean options enable_strict_check and password_authentication can be defined but set to false or any falsy value (I personally rely on URLs and query params)

@lyrixx
Copy link
Member

lyrixx commented Nov 13, 2024

Hello, I'm deeply sorry, but we don't want to use a fork in castor.

So I'm gonna close you PR.


For the record, we are a bit unhapy with spatie/ssh. If we could get ride of it, it would be nice.

Maybe we should try something with https://castor.jolicode.com/going-further/extending-castor/command-builder/?h=commandbuilderinterface

@lyrixx lyrixx closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants