-
Notifications
You must be signed in to change notification settings - Fork 13
add pre-commit and apply style fixes #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 2 2
Lines 207 207
=======================================
Hits 205 205
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
797b959 to
cdbd165
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are probably way more jobs than necessary. I also see a bug on a line not touched here. Maybe I can open follow-up PR after this to clean up the test matrix. See #83
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Regression tests:
Roman: https://github.com/spacetelescope/RegressionTests/actions/runs/19526625146
JWST: https://github.com/spacetelescope/RegressionTests/actions/runs/19526650745