Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: fix CI build & tests #325

Merged
merged 15 commits into from
May 9, 2024
Merged

MRG: fix CI build & tests #325

merged 15 commits into from
May 9, 2024

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented May 7, 2024

Fix broken CI. Among other things,actions-rs is unmaintained per actions-rs/toolchain#216. I think the original breakage might have been occasioned by the runner image for ubuntu-latest being updated about two weeks ago (link).

A laundry list of problems to fix seems to have boiled down to:

Fixes #321

@ctb ctb changed the title MRG: switch to dtolnay/rust-toolchain MRG: fix CI build & tests May 9, 2024
@ctb ctb merged commit acb991f into main May 9, 2024
1 check passed
@ctb ctb deleted the fix_ci branch May 9, 2024 12:41
bluegenes added a commit to sourmash-bio/sourmash_plugin_directsketch that referenced this pull request May 9, 2024
Fix broken CI, following sourmash-bio/sourmash_plugin_branchwater#325

> Fix broken CI. Among other things,`actions-rs` is unmaintained per actions-rs/toolchain#216. I think the original breakage might have been occasioned by the runner image for ubuntu-latest being updated about two weeks ago ([link](https://github.com/actions/runner-images/blob/ubuntu22/20240422.1/images/ubuntu/Ubuntu2204-Readme.md)).

A laundry list of problems to fix seems to have boiled down to:
* don't mix rustup installs with conda installs;
* if you're going to use conda-incubator/setup-miniconda, do not set `use-only-tar-bz2` to true (conda-incubator/setup-miniconda#267 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

continuous integration is failing with a rust link error
1 participant