Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add manifest summarization #3030

Open
wants to merge 14 commits into
base: latest
Choose a base branch
from
Open

WIP: add manifest summarization #3030

wants to merge 14 commits into from

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Feb 22, 2024

I went down a rabbithole while trying to write tests for safer selection... ended up implementing manifest summarization in rust. The output of write_summary mimics our current python manifest summarization (https://github.com/sourmash-bio/sourmash/blob/latest/src/sourmash/sig/__main__.py#L1309-L1407).

Since disk_revindex (rocksdb) are also collections with manifests, could we use this to summarize those?

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.91%. Comparing base (e0ed4c3) to head (3b17a9e).

Files Patch % Lines
src/core/src/collection.rs 50.00% 1 Missing ⚠️
src/core/src/manifest.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3030      +/-   ##
==========================================
+ Coverage   86.89%   86.91%   +0.01%     
==========================================
  Files         136      136              
  Lines       15542    15581      +39     
  Branches     2637     2637              
==========================================
+ Hits        13505    13542      +37     
- Misses       1735     1737       +2     
  Partials      302      302              
Flag Coverage Δ
hypothesis-py 25.44% <ø> (ø)
python 92.87% <ø> (ø)
rust 61.90% <94.87%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from safer-select to latest February 23, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant