Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace both airdrop functions with one that always checks the existing balance #14

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

mikemaccana
Copy link
Contributor

@mikemaccana mikemaccana commented Jan 23, 2024

Per #13

Also we need to use 'finalized'. While the balance may show updated after using 'confirmed', actually sending the airdropped tokens won't work unless it's 'finalized'.

@mikemaccana mikemaccana force-pushed the single-airdrop-function branch 2 times, most recently from 11a43b1 to 61c821f Compare February 5, 2024 21:59
Copy link
Member

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickfrosty nickfrosty merged commit 3b57e2f into main Feb 27, 2024
1 check passed
@nickfrosty nickfrosty deleted the single-airdrop-function branch February 27, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants