Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get logs, plus various minor fixes #21

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Add get logs, plus various minor fixes #21

merged 6 commits into from
Feb 27, 2024

Conversation

mikemaccana
Copy link
Contributor

Review and merge after #14 since this sits on top of that work. Once that's merged this will be much smaller.

  • Add getLogs() which gets logs from a transaction
  • Various minor fixes:
    • Need to set confirmation strategy explicitly
    • Remove an unused 'only' from tests
    • Remove not-not on null variable, since null is already falsy.

@nickfrosty nickfrosty merged commit 1cb179f into main Feb 27, 2024
1 check passed
@nickfrosty nickfrosty deleted the add-get-logs branch February 27, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants