Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import guid context var from context module #132

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

hartungstenio
Copy link
Contributor

This fixes two problems:

  1. Some tools complain that django_guid.middleware do not export guid symbol
  2. Importing from django_guid.middleware requires Django to be initialized. Importing from django_guid.context does not. This is useful to add the CorrelationId to Gunicorn access logs.

@JonasKs
Copy link
Member

JonasKs commented Sep 19, 2024

Thanks! 😊
What tool, if I may ask?

@hartungstenio
Copy link
Contributor Author

Thanks! 😊 What tool, if I may ask?

VSCode/pylance/pyright, for instance, emit a reportPrivateImportUsage

@JonasKs JonasKs merged commit cf849e3 into snok:main Sep 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants