[CRE-43] fix slicing of events #992
Open
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agparadiso
temporarily deployed
to
integration
GitHub Actions
Inactive
agparadiso
temporarily deployed
to
integration
GitHub Actions
Inactive
agparadiso
temporarily deployed
to
integration
GitHub Actions
Inactive
MStreet3
previously approved these changes
Jan 10, 2025
pkg/workflows/wasm/host/wasip1.go
Outdated
| outOffset := events[i*eventsLen] | ||
|
|
||
| slot := events[outOffset:] | ||
| outOffset := i * eventsLen |
There was a problem hiding this comment.
Where is eventsLen defined?
There was a problem hiding this comment.
this is a const defined here
agparadiso
force-pushed
the
CRE-43_incorrect_slicing_pullOneoff
branch
from
ff7307e to
74e909c
Compare
agparadiso
temporarily deployed
to
integration
GitHub Actions
Inactive
agparadiso
temporarily deployed
to
integration
GitHub Actions
Inactive
agparadiso
temporarily deployed
to
integration
GitHub Actions
Inactive
MStreet3
requested changes
Jan 10, 2025
pkg/workflows/wasm/host/wasip1.go
Outdated
| @@ -228,3 +231,14 @@ func createRandomGet(cfg *ModuleConfig) func(caller *wasmtime.Caller, buf, bufLe | |||
| return ErrnoSuccess | |||
| } | |||
| } | |||
|
|
|||
| func getSlot(events []byte, i int32) ([]byte, error) { | |||
| outOffset := i * eventsLen | |||
There was a problem hiding this comment.
Why the prefix out? Offset is simpler to understand
agparadiso
temporarily deployed
to
integration
GitHub Actions
Inactive
agparadiso
temporarily deployed
to
integration
GitHub Actions
Inactive
MStreet3
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original code was using the actual value of the []byte as an index
instead we are now calculating the index of the corresponding event and slicing it (given its a fixed lenght)
more info in the ticket
CRE-43
Requires
Supports