Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: draft: Add mitigation for compromised build tooling #1251

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

TomHennen
Copy link
Contributor

This threat can be mitigated in a number of ways, here I address it in the simplest one, verifying the tooling prior to use. You can also imagine resolving it by recording the digests in the provenance, and propagating VSAs so that downstream verifiers can verify recursively, but that's pretty complicated.

You can also resolve this with the attested build environments track, but I don't think we should mention that here until it's finalized? Or maybe we can point to it now as 'coming soon'?

fixes #1184

This threat can be mitigated in a number of ways, here I address it in the simplest one,
verifying the tooling prior to use.  You can also imagine resolving it by recording
the digests in the provenance, and propagating VSAs so that downstream verifiers can
verify recursively, but that's pretty complicated.

You can also resolve this with the attested build environments track, but I don't think
we should mention that here until it's finalized? Or maybe we can point to it now as
'coming soon'?

fixes slsa-framework#1184

Signed-off-by: Tom Hennen <[email protected]>
@TomHennen TomHennen requested review from lehors and arewm December 3, 2024 20:10
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 16a48db
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/6758be0f3ab58000089be254
😎 Deploy Preview https://deploy-preview-1251--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcelamelara
Copy link
Contributor

You can also resolve this with the attested build environments track, but I don't think we should mention that here until it's finalized? Or maybe we can point to it now as 'coming soon'?

As a status update, I am still hoping to open a PR before EOY where we describe the detailed verification requirements for the BuildEnv track.

That said, these requirements are already laid out at a high level in draft/attested-build-env-levels.md. Not sure what level of detail makes more sense for the threats page. And #1244 may actually be the more pertinent PR to have merged in the context of the updates in this PR.

@marcelamelara
Copy link
Contributor

marcelamelara commented Dec 4, 2024

And #1244 may actually be the more pertinent PR to have merged in the context of the updates in this PR.

Looking at the current 1.1RC terminology page, the terminology page with the build environment model isn't included. So, I think the most we should do at this point is say that the "upcoming build environment track may provide additional assurances against this threat"

docs/spec/draft/threats.md Outdated Show resolved Hide resolved
docs/spec/draft/threats.md Outdated Show resolved Hide resolved
docs/spec/draft/threats.md Outdated Show resolved Hide resolved
Signed-off-by: Tom Hennen <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
Copy link
Contributor

@zachariahcox zachariahcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change looks good to me

Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @TomHennen ! I'm happy to approve this once my comment has been resolved.

docs/spec/draft/threats.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @TomHennen !

docs/spec/draft/threats.md Outdated Show resolved Hide resolved
Co-authored-by: Marcela Melara <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
TomHennen and others added 2 commits December 10, 2024 17:13
Co-authored-by: Trishank Karthik Kuppusamy <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
@TomHennen TomHennen merged commit 44107e4 into slsa-framework:main Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TODO: Need mitigation description for "Use a compromised build tool" threat
5 participants