fix(core/chip, pill): removed default left margin from chip pill

[GayatriK2002]

💡 What is the current behavior?

• Chip and pill has default left margin

GitHub Issue Number: #
Jira Issue Number: 3178

🆕 What is the new behavior?

• Removed chip and pill default left margin

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

• 🦮 Accessibility (a11y) features were implemented
• 🗺️ Internationalization (i18n) - no hard coded strings
• 📲 Responsiveness - components handle viewport changes and content overflow gracefully
• 📕 Add or update a Storybook story
• 📄 Documentation was reviewed/updated siemens/ix-docs
• 🧪 Unit tests were added/updated and pass (pnpm test)
• 📸 Visual regression tests were added/updated and pass (Guide)
• 🧐 Static code analysis passes (pnpm lint)
• 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

[changeset-bot]

🦋 Changeset detected

Latest commit: e126e92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@siemens/ix	Major
@siemens/ix-aggrid	Patch
@siemens/ix-angular	Major
@siemens/ix-docs	Major
@siemens/ix-react	Major
@siemens/ix-vue	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @GayatriK2002, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the flexibility of the 'ix-chip' and 'ix-pill' components by eliminating their default left margins. This change allows developers greater control over component spacing and alignment. To ensure visual consistency and prevent regressions, the corresponding visual test cases have been updated to explicitly apply the previously implicit margins, maintaining the intended appearance of these components in their test environments.

Highlights

• Default Margin Removal: The default 'margin-left' property has been removed from the core 'ix-chip' and 'ix-pill' component styles, providing more control over their spacing.
• Visual Test Adjustments: Visual regression test files for 'chip' and 'pill' components were updated to explicitly re-introduce the 'margin-left' where necessary, ensuring no visual changes in existing test cases.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the default left margin from the chip and pill components, which is a good change to give consumers more control over layout. The related updates to the visual regression tests are mostly fine, but I've found an opportunity to improve the maintainability of one of the test files (testing/visual-testing/tests/pill/basic/index.html). Instead of using a combination of text-align: center and removing whitespace between elements with ><, I've suggested using display: flex with the gap property, which is a cleaner and more modern approach for layout spacing.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud