fix(core/chip, pill): removed left margin css from pill chip#2281
fix(core/chip, pill): removed left margin css from pill chip#2281GayatriK2002 wants to merge 11 commits intosiemens:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 526e9d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nuke-ellington
left a comment
nuke-ellington
left a comment
There was a problem hiding this comment.
The chip and pill snapshots should still have margins. Please add them via style tags.
There was a problem hiding this comment.
This example should not have the margin
There was a problem hiding this comment.
The blind/custom-header VRT contains ix-pill components, so I added the left margin in the custom-header VRT. Without it, the VRT was failing.
There was a problem hiding this comment.
Is there are reason these changed. Margin should be the same?
|
|
Closing this PR due to wrong VRT update. I've opened a new PR, #2309 , with the same changes. Please continue the review there. |
2 participants
💡 What is the current behavior?
GitHub Issue Number: #
Jira Issue Number: 3178
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support