Updated sinatra version to 2.0 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bundler dependency issues with rails >5.0 and rack 2.0.
thinkingserious
added
the
status: code review request
|
|
|
To whoever reviews this, please note that I had some trouble running the tests locally. Setup:
I had to change |
|
Last thing, if it helps, I added a local build of the gem in an existing Ruby v2.3 and Rails v5.0 project with a bunch of other gems. Bundler installs like a charm. |
thinkingserious
added a commit
that referenced
this pull request
Apr 25, 2017
|
@elmer, you guys should hard code the version of prism, or always download the latest 0.x.x release. 2.x.x is a completely different version of prism and it will break all your tests. I would check all your sdks to make sure they aren't downloading latest version of prism. |
skalee
added a commit
to skalee/sendgrid-ruby
that referenced
this pull request
May 2, 2017
Fixes breaking change introduced in bd72df0 (sendgrid#160), and also fixes the issue reported in sendgrid#159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bundler dependency issues with rails >5.0 and rack 2.0.
Solves: #159