Fixed problematic Sinatra dependency #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes breaking change introduced in bd72df0 (sendgrid#160), and also fixes the issue reported in sendgrid#159.
thinkingserious
added
the
status: code review request
|
|
|
Alternatively, I would consider extracting Sinatra-based parts to another gem, so that the basic Sendgrid-Ruby gem does not introduce many dependencies. |
|
The Sinatra dependency is only needed for those setting up an Inbound Parse Webhook server. What do you think about these options:
I'm favoring option 2 as a quick fix for now. Thoughts? |
|
Hello @skalee, |
thinkingserious
added a commit
that referenced
this pull request
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back Rails 4 compatibility (and Rack 1.x applications, in general), also removes release candidate version constraint (both broken in #160). Moreover, ensures that tests are run against two major Sinatra versions, which should protect from compatibility issues in future, somewhat.
Related issue: #159.