Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing bypass settings to MailSettings #707

Merged
merged 4 commits into from
Nov 1, 2021
Merged

fix: Add missing bypass settings to MailSettings #707

merged 4 commits into from
Nov 1, 2021

Conversation

arkitex
Copy link
Contributor

@arkitex arkitex commented Oct 29, 2021 •
edited by shwetha-manvinkurke
Loading

Fixes part of #700

This PR adds missing bypass settings to MailSettings.java. See associated issue. Updated test.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@arkitex arkitex mentioned this pull request Nov 1, 2021
Open
shwetha-manvinkurke
shwetha-manvinkurke reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an example here?

src/main/java/com/sendgrid/helpers/mail/objects/MailSettings.java Show resolved Hide resolved
@arkitex
Copy link
Contributor Author

arkitex commented Nov 1, 2021

@shwetha-manvinkurke done!

@shwetha-manvinkurke shwetha-manvinkurke merged commit 7a58fcd into sendgrid:main Nov 1, 2021
@danitnegbi
Copy link

Great for fixing that!
when it will be released? I'm currently using sendgrid and need the setBypassSpamManagement

@shwetha-manvinkurke
Copy link
Contributor

It's currently scheduled for release tomorrow (11/3)

@arkitex arkitex deleted the elo/mailsettings branch November 3, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diffractious-zz diffractious-zz diffractious-zz approved these changes

@shwetha-manvinkurke shwetha-manvinkurke shwetha-manvinkurke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkitex @danitnegbi @shwetha-manvinkurke @diffractious-zz