Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers do not have all properties #700

Open
lopenchi opened this issue Sep 7, 2021 · 2 comments
Open

Helpers do not have all properties #700

lopenchi opened this issue Sep 7, 2021 · 2 comments
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@lopenchi
Copy link

lopenchi commented Sep 7, 2021

Issue Summary

Checking the request body for mail/send (https://docs.sendgrid.com/api-reference/mail-send/mail-send), it was discovered that helper classes provided in this library are old and do not contain all info needed.

Errors found:

  • In mail_settings object, there are some properties that are not in MailSettings helper class: bypass_spam_management, bypass_bounce_management and bypass_unsubscribe_management

  • In MailSettings helper class there is a property bcc that it is not described anymore in the request body

@JenniferMah JenniferMah added status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Sep 9, 2021
@JenniferMah
Copy link
Contributor

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@arkitex
Copy link
Contributor

arkitex commented Nov 1, 2021

@JenniferMah hi folks - added a PR to address the first point: #707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants