Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailSettings class missing attributes from specification #1135

Closed
fefi95 opened this issue Oct 11, 2021 · 4 comments
Closed

MailSettings class missing attributes from specification #1135

fefi95 opened this issue Oct 11, 2021 · 4 comments
Labels
type: community enhancement feature request not on Twilio's roadmap

Comments

@fefi95
Copy link

fefi95 commented Oct 11, 2021

Issue Summary

The specification for Sendgrid's API version 3 has the attributes bypass_spam_management , bypass_bounce_management and bypass_unsubscribe_management on mail_settings for the /mail/send endpoint. However, they seem to be missing on MailSettings class. Could they be added? Thanks!

Technical details:

  • sendgrid-csharp version: 9.24.3
@Jericho
Copy link

Jericho commented Oct 12, 2021

@fefi95 You should consider using StrongGrid because it allows you to configure all the mail settings, including the bypass_xxxx_management, when sending an email. Here is an example that shows how you would configure some of the mail settings:

var apiKey = "... your api key...";
var client = new StrongGrid.Client(apiKey);

var result = await client.Mail.SendToSingleRecipientAsync(
    to,
    from,
    subject,
    htmlContent,
    textContent,
    mailSettings: new MailSettings()
    {
        BypassBounceManagement = false,
        BypassListManagement = false,
        BypassSpamManagement = true,
        BypassUnsubscribeManagement = false,
        ... other settings omitted ...
    },
    cancellationToken: cancellationToken).ConfigureAwait(false);

@eshanholtz
Copy link
Contributor

Similar to sendgrid/sendgrid-java#700. This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@eshanholtz eshanholtz added status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Oct 14, 2021
@Felix200521
Copy link

Problemzusammenfassung

Die Spezifikation für Sendgrids API Version 3 hat die Attribute bypass_spam_management, bypass_bounce_managementund bypass_unsubscribe_managementon mail_settingsfür den /mail/sendEndpunkt. Sie scheinen jedoch in der MailSettings- Klasse zu fehlen . Könnten sie hinzugefügt werden? Danke!

Technische Details:

  • sendgrid-csharp-Version: 9.24.3

asos-vinodpatil added a commit to asos-vinodpatil/sendgrid-csharp that referenced this issue Jan 7, 2022
rakatyal added a commit that referenced this issue Mar 10, 2022
…ss_bou… (#1153)

* Added mail settings attributes for bypass_spam_management, bypass_bounce_management and bypass_unsubscribe_management
#1135

* Documentation for bypass_spam_management, bypass_bounce_management and bypass_unsubscribe_management

* Review comments- Udated right summary from the api spec

Co-authored-by: Shwetha Radhakrishna <[email protected]>
Co-authored-by: Jennifer Mah <[email protected]>
Co-authored-by: Raghav Katyal <[email protected]>
@rakatyal
Copy link
Contributor

This should be resolved now. Thank you for the issue and community PR.

@childish-sambino childish-sambino removed the status: help wanted requesting help from the community label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

6 participants