Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added mail settings attributes for bypass_spam_management, bypass_bou… #1153

Merged
merged 7 commits into from
Mar 10, 2022

Conversation

asos-vinodpatil
Copy link
Contributor

@asos-vinodpatil asos-vinodpatil commented Jan 7, 2022

…nce_management and bypass_unsubscribe_management

#1135

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asos-vinodpatil! Thanks for your PR! Would you mind adding some documentation for spam, bounce, and unsubscribe bypass management filters in the Usage.md and Use_cases.md? Here's an example of the documentation in php.

@asos-vinodpatil
Copy link
Contributor Author

Hi @asos-vinodpatil! Thanks for your PR! Would you mind adding some documentation for spam, bounce, and unsubscribe bypass management filters in the Usage.md and Use_cases.md? Here's an example of the documentation in php.

Thanks @JenniferMah, added required documentation.

@asos-vinodpatil
Copy link
Contributor Author

@JenniferMah Any update on this PR

@shwetha-manvinkurke shwetha-manvinkurke changed the title Added mail settings attributes for bypass_spam_management, bypass_bou… feat: Added mail settings attributes for bypass_spam_management, bypass_bou… Feb 2, 2022
@rakatyal
Copy link
Contributor

Thank you for the PR. LGTM!

@rakatyal rakatyal merged commit 5ed9472 into sendgrid:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants