Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change poliastro periodicity #271

Closed
wants to merge 2 commits into from

Conversation

astrojuanlu
Copy link
Contributor

(Do not merge, still pending confirmation)

By the way, I guess it's not possible to specify "first Wednesday of every month"?

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for scientific-python-org ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3fb9417
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-org/deploys/62dfb1abb1d72b00084483e5
😎 Deploy Preview https://deploy-preview-271--scientific-python-org.netlify.app/calendars
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tupui
Copy link
Member

tupui commented Jul 26, 2022

Ok I will wait for your signal 👍

By the way, I guess it's not possible to specify "first Wednesday of every month"?

It should be possible to do something like that as you can go crazy with the recurring rules. See: https://icalendar.org/iCalendar-RFC-5545/3-8-5-3-recurrence-rule.html
You could try to write the yml with the custom RRULE and locally create the ics to check it's valid.

[EDIT:] Should be something like
RRULE:FREQ=MONTHLY;BYDAY=1WE

@astrojuanlu
Copy link
Contributor Author

Thanks @tupui! However it's not clear to me where could I write the RRULE, since yaml2ics.py builds the rrule according to a few fixed interval types:

https://github.com/scientific-python/yaml2ics/blob/caaa5b551a65cb8aafac7cb1778238f4c130d688/yaml2ics.py#L75-L80

Should I commit the .ics instead, open an issue in yaml2ics, or am I missing something?

@tupui
Copy link
Member

tupui commented Jul 27, 2022

Right, me might be missing something in yaml2ics 👍

We don't yet have a way to only add the .ics. At the moment yml are parsed to generate ics and then these are added to the template. But we want to allow adding directly ics (or a link to an existing ics), see #246. If you are interested to work on this, that would be great 😃

@astrojuanlu
Copy link
Contributor Author

I'd be happy to contribute on this area 😊 Maybe we can do it in 2 parts?

  • Add a "scape hatch" to yaml2ics so that folks can specify the rrule of their liking in text form (should be easier, and would solve my use case)
  • Add the possibility for projects to specify a URL with an ICS calendar directly instead of the YAML (more difficult, but would solve many projects use case, especially bigger ones with existing calendars)

How does that sound?

@tupui
Copy link
Member

tupui commented Aug 4, 2022

I'd be happy to contribute on this area 😊 Maybe we can do it in 2 parts?

Yay thank you for helping us! Sorry I did not have time so far so that's great if you can help.

  • Add a "scape hatch" to yaml2ics so that folks can specify the rrule of their liking in text form (should be easier, and would solve my use case)
  • Add the possibility for projects to specify a URL with an ICS calendar directly instead of the YAML (more difficult, but would solve many projects use case, especially bigger ones with existing calendars)

How does that sound?

Sounds perfect and yes can be 2 PRs of course.

@stefanv
Copy link
Member

stefanv commented Sep 20, 2022

My opinion: yes on custom rrules, maybe hold off on custom ics? This should solve the immediate problem without complicating our infrastructure.

@stefanv
Copy link
Member

stefanv commented Sep 20, 2022

I see astropy and pandas all want custom ics, so looks like I should do it after all.

@tupui
Copy link
Member

tupui commented Nov 2, 2022

@astrojuanlu in case you missed this, we can now have custom RRULE thanks to scientific-python/yaml2ics#41

@astrojuanlu
Copy link
Contributor Author

Hi folks, sorry but I have reconsidered some of my priorities and as a result I recently stepped down as poliastro maintainer. The truth is that we haven't been having these community meetings for some time and probably the best course of action short term is for me to close this PR and instead delete the event until @jorgepiloto, who is now gradually taking over the package, decides what to do with them.

Thanks everyone for your patience 🙏🏽

@astrojuanlu astrojuanlu closed this Mar 5, 2023
@astrojuanlu astrojuanlu deleted the patch-1 branch March 5, 2023 12:48
@astrojuanlu astrojuanlu mentioned this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants