-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change poliastro periodicity #271
Conversation
✅ Deploy Preview for scientific-python-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Ok I will wait for your signal 👍
It should be possible to do something like that as you can go crazy with the recurring rules. See: https://icalendar.org/iCalendar-RFC-5545/3-8-5-3-recurrence-rule.html [EDIT:] Should be something like |
Thanks @tupui! However it's not clear to me where could I write the Should I commit the |
Right, me might be missing something in yaml2ics 👍 We don't yet have a way to only add the .ics. At the moment yml are parsed to generate ics and then these are added to the template. But we want to allow adding directly ics (or a link to an existing ics), see #246. If you are interested to work on this, that would be great 😃 |
I'd be happy to contribute on this area 😊 Maybe we can do it in 2 parts?
How does that sound? |
Yay thank you for helping us! Sorry I did not have time so far so that's great if you can help.
Sounds perfect and yes can be 2 PRs of course. |
My opinion: yes on custom rrules, maybe hold off on custom ics? This should solve the immediate problem without complicating our infrastructure. |
I see astropy and pandas all want custom ics, so looks like I should do it after all. |
@astrojuanlu in case you missed this, we can now have custom RRULE thanks to scientific-python/yaml2ics#41 |
Hi folks, sorry but I have reconsidered some of my priorities and as a result I recently stepped down as poliastro maintainer. The truth is that we haven't been having these community meetings for some time and probably the best course of action short term is for me to close this PR and instead delete the event until @jorgepiloto, who is now gradually taking over the package, decides what to do with them. Thanks everyone for your patience 🙏🏽 |
(Do not merge, still pending confirmation)
By the way, I guess it's not possible to specify "first Wednesday of every month"?