This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Use array of concrete eltype for efficiency in astar #1585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An array of eltype
Integer
is used in the astar algorithm. But, the elements are always only of a single concrete subtype ofInteger
. This PR changes the array to the narrower type. Timing the second test of astar in the test suite (applying astar to the complete graph) shows a 2x improvement in speed.EDIT: it would be better if
ones(Integer, n)
threw an error, rather than arbitrarily choosing to fill withInt
s. But, that ship has sailed.