Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #9

Merged
merged 4 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/gradle-wrapper-validation.yml

This file was deleted.

14 changes: 8 additions & 6 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: Main CI
name: Main
on: [push]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
spotless:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -40,9 +44,10 @@ jobs:
if: github.ref == 'refs/heads/main'
environment: Sonatype
env:
ORG_GRADLE_PROJECT_sonatypePass: ${{ secrets.SONATYPE_API_KEY }}
ORG_GRADLE_PROJECT_sonatypeUser: ${{ secrets.SONATYPE_USER }}
SONATYPE_GPG_KEY: ${{ secrets.SONATYPE_GPG_KEY }}
SONATYPE_GPG_KEY_PASSWORD: ${{ secrets.SONATYPE_GPG_KEY_PASSWORD }}
SECRETS_KEY: ${{ secrets.SECRETS_KEY }}
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand All @@ -56,7 +61,4 @@ jobs:
name: kase64_build
- name: Publish to Sonatype (Maven Central)
shell: bash
run: |
brew install gnupg
./scripts/secret decrypt --password ${SECRETS_KEY}
./scripts/publish
run: ./scripts/publish
20 changes: 15 additions & 5 deletions .github/workflows/mobsf.yml → .github/workflows/security.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
name: MobSF
name: Security
on: [push]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
mobile-security:
mobfs:
permissions:
contents: read # for actions/checkout to fetch code
security-events: write # for github/codeql-action/upload-sarif to upload SARIF results
Expand All @@ -12,12 +16,18 @@ jobs:
- name: Setup Python 3.10
uses: actions/setup-python@v4
with:
python-version: 3.10
python-version: '3.11'
- name: Run mobsfscan
uses: MobSF/mobsfscan@a60d10a83af68e23e0b30611c6515da604f06f65
uses: MobSF/mobsfscan@0.3.4
with:
args: . --sarif --output results.sarif || true
- name: Upload mobsfscan report
uses: github/codeql-action/upload-sarif@v2
with:
sarif_file: results.sarif
sarif_file: results.sarif

gradle-validate:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: gradle/wrapper-validation-action@v1
Empty file added .gitlab-ci.yml
Empty file.
2 changes: 1 addition & 1 deletion .idea/compiler.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]
### Changed
- Android: Compile with API level 33 / Android 13
- Dependency update:
- [Android Gradle Plugin 7.2.2](https://developer.android.com/studio/releases/gradle-plugin#7-2-0)
- [Android Gradle Plugin 8.1.0-rc01](https://developer.android.com/studio/releases/gradle-plugin#7-2-0)
- [Gradle-7.5.1](https://docs.gradle.org/7.5.1/release-notes.html)
- [Kotlin 1.9.10](https://github.com/JetBrains/kotlin/releases/tag/v1.9.10)

Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins {
kotlin("jvm") version "1.9.10"
id("com.android.library") version "7.2.2" apply false
id("com.android.library") version "8.1.0-rc01" apply false
id("com.diffplug.spotless") version "6.21.0"
id("com.github.ben-manes.versions") version "0.47.0"
}
Expand Down
1 change: 0 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ kotlin.mpp.stability.nowarn=true
# Android
android.enableJetifier=true
android.injected.testOnly=false
android.testConfig.useRelativePath=true
android.useAndroidX=true
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
3 changes: 2 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-all.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
12 changes: 8 additions & 4 deletions gradlew
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
# Darwin, MinGW, and NonStop.
#
# (3) This script is generated from the Groovy template
# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
# within the Gradle project.
#
# You can find Gradle at https://github.com/gradle/gradle/.
Expand All @@ -80,10 +80,10 @@ do
esac
done

APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

APP_NAME="Gradle"
# This is normally unused
# shellcheck disable=SC2034
APP_BASE_NAME=${0##*/}
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
Expand Down Expand Up @@ -143,12 +143,16 @@ fi
if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
case $MAX_FD in #(
max*)
# In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
# shellcheck disable=SC3045
MAX_FD=$( ulimit -H -n ) ||
warn "Could not query maximum file descriptor limit"
esac
case $MAX_FD in #(
'' | soft) :;; #(
*)
# In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
# shellcheck disable=SC3045
ulimit -n "$MAX_FD" ||
warn "Could not set maximum file descriptor limit to $MAX_FD"
esac
Expand Down
1 change: 1 addition & 0 deletions gradlew.bat
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ if "%OS%"=="Windows_NT" setlocal

set DIRNAME=%~dp0
if "%DIRNAME%"=="" set DIRNAME=.
@rem This is normally unused
set APP_BASE_NAME=%~n0
set APP_HOME=%DIRNAME%

Expand Down
33 changes: 19 additions & 14 deletions kase64/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ kotlin {
jvm { testRuns["test"].executionTask.configure { useJUnitPlatform() } }
linuxX64()
macosArm64()
mingwX64() // Winwhat?!?
mingwX64() // Win-what ?!?
// tvos()
// watchos()

Expand All @@ -34,18 +34,21 @@ kotlin {
}
}

java {
toolchain {
languageVersion.set(JavaLanguageVersion.of(17))
}
}

android {
buildToolsVersion = "32.0.0"
compileSdk = 31
compileSdk = 33
namespace = "saschpe.kase64"

defaultConfig {
minSdk = 17
targetSdk = 31
}

sourceSets["main"].manifest.srcFile("src/androidMain/AndroidManifest.xml")

testCoverage.jacocoVersion = "0.8.8"
testCoverage.jacocoVersion = "0.8.10"
}

group = "de.peilicke.sascha"
Expand Down Expand Up @@ -85,14 +88,16 @@ publishing {
}
}

repositories {
maven {
name = "sonatype"
credentials {
username = Secrets.Sonatype.user
password = Secrets.Sonatype.apiKey
if (hasProperty("sonatypeUser") && hasProperty("sonatypePass")) {
repositories {
maven {
name = "sonatype"
credentials {
username = property("sonatypeUser") as String
password = property("sonatypePass") as String
}
url = uri("https://oss.sonatype.org/service/local/staging/deploy/maven2")
}
url = uri("https://oss.sonatype.org/service/local/staging/deploy/maven2")
}
}
}
Expand Down
1 change: 0 additions & 1 deletion kase64/src/androidMain/AndroidManifest.xml

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/publish
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash
#
# Script to publish libary in case a release commit is discovered
# Script to publish a library in case a release commit is discovered
#

SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
Expand Down
74 changes: 0 additions & 74 deletions scripts/secret

This file was deleted.